fix: ligthouse check failure fix #4062

sambhavgupta0705 · 2025-04-25T10:29:42Z

Summary by CodeRabbit

Chores
- Updated versions of actions used in the Lighthouse CI workflow for improved reliability and compatibility.

coderabbitai · 2025-04-25T10:29:49Z

Walkthrough

The workflow file for Lighthouse CI in the GitHub Actions configuration has been updated to use newer versions of its dependencies. Specifically, the actions/checkout action is changed from a fixed version v3 to the generic v tag, and the treosh/lighthouse-ci-action is upgraded from version 10.1.0 to version 11.4.0 via commit hashes. The URL parameter now uses GitHub Actions expression syntax for the pull request number instead of a shell variable, and the environment variable PR_NUMBER was removed. Additionally, a new input parameter artifactName was added to the Lighthouse audit step. No changes were made to the control flow or logic of the workflow, and no exported or public entities were altered.

Changes

File(s)	Change Summary
.github/workflows/lighthouse-ci.yml	Updated `actions/checkout` from fixed `v3` to generic `v`; upgraded `treosh/lighthouse-ci-action` from version 10.1.0 to 11.4.0 commit hash; replaced shell variable `$PR_NUMBER` with `${{ github.event.pull_request.number }}`; removed `PR_NUMBER` environment variable; added `artifactName` input parameter.

Suggested reviewers

akshatnema
anshgoyalevil

Poem

A hop and a skip, new versions in tow,
The workflow is fresher, as updates now show.
With checkout on four, and Lighthouse anew,
The CI hops forward, its tasks to pursue.
🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d660173 and 7c58dcc.

📒 Files selected for processing (1)

.github/workflows/lighthouse-ci.yml (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/lighthouse-ci.yml

⏰ Context from checks skipped due to timeout of 180000ms (3)

GitHub Check: Redirect rules - asyncapi-website
GitHub Check: Header rules - asyncapi-website
GitHub Check: Pages changed - asyncapi-website

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-04-25T10:30:01Z

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`e9541db`
🔍 Latest deploy log	https://app.netlify.com/projects/asyncapi-website/deploys/68277f45fbf6dc00087425f4
😎 Deploy Preview	https://deploy-preview-4062--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

codecov · 2025-04-25T10:31:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0d71c96) to head (e9541db).

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #4062   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          778       778           
  Branches       144       144           
=========================================
  Hits           778       778

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

.github/workflows/lighthouse-ci.yml (2)
38-38: Verify compatibility for actions/checkout@v4
actions/checkout v4 introduces changes to defaults (e.g., fetch-depth) and new features. If any downstream step relies on full Git history (tags, full commit logs, submodules, etc.), consider explicitly setting:
- uses: actions/checkout@v4
  with:
    fetch-depth: 0
Otherwise a shallow clone may lead to unexpected behavior.

51-51: Consider using a semantic version tag for treosh/lighthouse-ci-action
Pinning to a commit hash (2f8dda6cf4d…) guarantees immutability but can be less readable. For clarity, you may switch to the official release tag:
uses: treosh/[email protected]
or
uses: treosh/lighthouse-ci-action@v10
If stability is your top priority, the existing commit pin is also acceptable.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63cbfab and 2569a2a.

📒 Files selected for processing (1)

.github/workflows/lighthouse-ci.yml (2 hunks)

⏰ Context from checks skipped due to timeout of 180000ms (4)

GitHub Check: Redirect rules - asyncapi-website
GitHub Check: Header rules - asyncapi-website
GitHub Check: Pages changed - asyncapi-website
GitHub Check: Lighthouse CI

aeworxet · 2025-04-28T10:45:36Z

@asyncapi/bounty_team

anshgoyalevil · 2025-05-11T15:11:29Z

@sambhavgupta0705 The workflow is still failing in CI. Will that be resolved post-merge? Can you please share a link to the workflow passing in your forked repository?

sambhavgupta0705 · 2025-05-16T17:13:14Z

Hey
Would like to extend this issue

akshatnema · 2025-05-24T10:32:42Z

.github/workflows/lighthouse-ci.yml

@@ -35,7 +35,7 @@ jobs:
        run: echo "shouldrun=true" >> $GITHUB_OUTPUT

      - if: steps.should_run.outputs.shouldrun == 'true'
-        uses: actions/checkout@v3
+        uses: actions/checkout@v

      - if: steps.should_run.outputs.shouldrun == 'true'
        name: Await Netlify Preview


@sambhavgupta0705 Are we sure that it is waiting for netlify deployment to complete? Also, what if netlify deployment fails on latest commit?

akshatnema · 2025-05-24T10:33:49Z

.github/workflows/lighthouse-ci.yml

Can you please look into the workflow again? It is still failing in your PR. You can also look into a completely different approach to get Lighthouse results.

initial commit

2569a2a

sambhavgupta0705 requested review from derberg, akshatnema, anshgoyalevil, Mayaleeeee and asyncapi-bot-eve as code owners April 25, 2025 10:29

asyncapi-bot requested review from devilkiller-ag and vishvamsinh28 April 25, 2025 10:29

coderabbitai bot reviewed Apr 25, 2025

View reviewed changes

sambhavgupta0705 changed the title ~~fix : ligthouse check failure fix~~ fix: ligthouse check failure fix Apr 25, 2025

sambhavgupta0705 and others added 3 commits April 25, 2025 16:48

version change

d660173

clean up

7c58dcc

Merge branch 'master' into lighthouse-fix

9839e11

asyncapi-bot added the bounty AsyncAPI Bounty program related label label Apr 28, 2025

aeworxet added this to Bounty Program Apr 28, 2025

aeworxet moved this to In Progress in Bounty Program Apr 29, 2025

aeworxet mentioned this pull request Apr 30, 2025

[BUG] Fix Lighthouse workflow #3842

Open

2 tasks

Merge branch 'master' into lighthouse-fix

578a8ca

Merge branch 'master' into lighthouse-fix

e9541db

akshatnema reviewed May 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: ligthouse check failure fix #4062

fix: ligthouse check failure fix #4062

sambhavgupta0705 commented Apr 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 25, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

netlify bot commented Apr 25, 2025 •

edited

Loading

Uh oh!

codecov bot commented Apr 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

aeworxet commented Apr 28, 2025

Uh oh!

anshgoyalevil commented May 11, 2025

Uh oh!

sambhavgupta0705 commented May 16, 2025

Uh oh!

akshatnema May 24, 2025

Uh oh!

akshatnema May 24, 2025

Uh oh!

Uh oh!

Uh oh!

fix: ligthouse check failure fix #4062

Are you sure you want to change the base?

fix: ligthouse check failure fix #4062

Conversation

sambhavgupta0705 commented Apr 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

netlify bot commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for asyncapi-website ready!

Uh oh!

codecov bot commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

aeworxet commented Apr 28, 2025

Uh oh!

anshgoyalevil commented May 11, 2025

Uh oh!

sambhavgupta0705 commented May 16, 2025

Uh oh!

akshatnema May 24, 2025

Choose a reason for hiding this comment

Uh oh!

akshatnema May 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sambhavgupta0705 commented Apr 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 25, 2025 •

edited

Loading

netlify bot commented Apr 25, 2025 •

edited

Loading

codecov bot commented Apr 25, 2025 •

edited

Loading