-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: replace bitly urls with netlify redirect #4647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThis PR updates the default AsyncAPI specification URL across the website and generator configuration. It replaces the shortened bit.ly URL with a new full URL (asyncapi.com/s/asyncapiv2) in the generator component, configuration files, documentation examples, and blog posts, along with a corresponding redirect rule. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🧰 Additional context used🧠 Learnings (4)📓 Common learnings📚 Learning: 2025-01-19T04:51:41.255ZApplied to files:
📚 Learning: 2025-01-18T08:44:43.614ZApplied to files:
📚 Learning: 2025-07-19T20:58:34.040ZApplied to files:
🪛 LanguageToolmarkdown/blog/february-2021-at-asyncapi.md[style] ~44-~44: Consider using “unable” to avoid wordiness. (NOT_ABLE_PREMIUM) ⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (5)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4647--asyncapi-website.netlify.app/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4647 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 799 799
Branches 146 146
=========================================
Hits 799 799 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
princerajpoot20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@vishvamsinh28 Can you please do one thing? Please attach the testing evidence in the issue, just to make sure everything looks good. Thanks. |
|
/rtm |
|
@TRohit20 PTAL |
|
@TRohit20 @thulieblack you need to approve as well as there are markdown files |
This PR replaces all bit.ly short URLs with /s path, using Netlify’s _redirects functionality. All occurrences across the codebase have been updated accordingly.
part of #3005
Summary by CodeRabbit
Release Notes
Updates
Documentation
Infrastructure
✏️ Tip: You can customize this high-level summary in your review settings.