-
-
Notifications
You must be signed in to change notification settings - Fork 1k
docs: add django and fastapi to technologies #4681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis PR adds support for Django and FastAPI as recognized technologies by inserting two new entries with color configurations into the project's technology registry files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3–5 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4681 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 799 799
Branches 146 146
=========================================
Hits 799 799 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/all-tags.json (1)
175-184: Reorder entries to match TypeScript file.The Django and FastAPI entries are correctly formatted and have matching colors with
scripts/tools/tags-color.ts. However, the ordering differs from the TypeScript file. For consistency and maintainability, the order should match across both files.In TypeScript: Flask → Nest Js → Django → FastAPI
In JSON: Flask → Django → FastAPI → Nest JsApply this diff to align the ordering:
{ "name": "Flask", "color": "bg-[#D7C7F2]", "borderColor": "border-[#A387D2]" }, + { + "name": "Nest Js", + "color": "bg-[#E1224E]", + "borderColor": "border-[#B9012b]" + }, { "name": "Django", "color": "bg-[#A3D9B1]", "borderColor": "border-[#0C4B33]" }, { "name": "FastAPI", "color": "bg-[#7DD3C0]", "borderColor": "border-[#009688]" }, - { - "name": "Nest Js", - "color": "bg-[#E1224E]", - "borderColor": "border-[#B9012b]" - },
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/all-tags.json(1 hunks)scripts/tools/tags-color.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
scripts/tools/tags-color.ts (1)
172-182: Good additions! Verify ordering consistency with config/all-tags.json.The Django and FastAPI entries are correctly structured with appropriate colors. Ensure the ordering of these technologies in
scripts/tools/tags-color.tsmatches the sequence inconfig/all-tags.jsonfor consistency across configuration files.
Description
Related issue(s)
Resolves #4680
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.