Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg,
princerajpoot20 and
sambhavgupta0705
as code owners
📝 WalkthroughWalkthroughThis PR updates configuration files by swapping language and technology tag names in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-01-19T04:51:41.255ZApplied to files:
📚 Learning: 2024-11-01T12:48:22.034ZApplied to files:
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4933 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4933--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (7)
config/tools.json (3)
2700-2751: Critical: Duplicate "asyncapi-preview" entries with test repository URL.Two "asyncapi-preview" entries exist:
- Line 2704:
https://github.com/Savio629/testing2— clearly a test repository based on the name- Line 2730:
https://github.com/asyncapi/vs-asyncapi-preview— the official repository ✓The entry pointing to
Savio629/testing2should be removed. The repository name itself indicates it's a test repository and not a legitimate tool.
2845-2925: Critical: Duplicate "HTML Template" entries with personal repository URLs.Three "HTML Template" entries exist:
- Line 2849:
https://github.com/WSOL12/html-template— personal fork, description isnull- Line 2876:
https://github.com/dipaksodani/async-gen— personal repository with different name, description isnull- Line 2903:
https://github.com/asyncapi/html-template— the official repository ✓Only the official
asyncapi/html-templateentry (lines 2899-2924) should be retained. The other entries appear to be personal forks that were incorrectly detected as separate tools by the automation.
1348-1428: Critical: Remove duplicate "AsyncAPI Studio" entries pointing to unofficial repositories.Three entries with title "AsyncAPI Studio" exist (lines 1349, 1376, 1403):
- Line 1349:
https://github.com/Shurtu-gal/action-test-bed— test repository,description: null- Line 1376:
https://github.com/asyncapi/studio— official repository ✓- Line 1403:
https://github.com/TahaShahid203/async-api-issue— personal fork,description: nullKeep only the official entry (line 1376). Remove entries at lines 1349 and 1403. The same pattern affects other tools:
asyncapi-preview(lines 2701, 2727) andHTML Template(lines 2846, 2873, 2900) also have duplicates with unofficial repository URLs. All duplicate entries with non-official repositories should be removed.config/tools-automated.json (4)
346-406: Critical: Editors section contains duplicate AsyncAPI Studio entries from personal repositories.The same issue identified in
tools.jsonexists here:
- Line 354:
https://github.com/Shurtu-gal/action-test-bedwithisAsyncAPIOwner: false- Line 373:
https://github.com/asyncapi/studiowithisAsyncAPIOwner: true✓- Line 392:
https://github.com/TahaShahid203/async-api-issuewithisAsyncAPIOwner: falseWhile
isAsyncAPIOwnercorrectly flags the official entry, the automation should not be adding personal forks/test repositories as tool entries in the first place. These appear to be forks that were incorrectly identified as tools with the.asyncapi-toolmarker file.
874-934: Critical: IDE Extensions section contains duplicate asyncapi-preview entry from test repository.
- Line 881:
https://github.com/Savio629/testing2withisAsyncAPIOwner: false- Line 899:
https://github.com/asyncapi/vs-asyncapi-previewwithisAsyncAPIOwner: true✓The
Savio629/testing2repository is clearly a test repository and should not be listed as a tool.
936-1091: Critical: AsyncAPI Generator Templates section contains duplicate HTML Template entries.Multiple HTML Template entries exist:
- Line 965:
https://github.com/WSOL12/html-templatewithisAsyncAPIOwner: false- Line 1060:
https://github.com/dipaksodani/async-genwithisAsyncAPIOwner: false- Line 1078:
https://github.com/asyncapi/html-templatewithisAsyncAPIOwner: true✓The automation is incorrectly detecting personal forks as separate tools.
1-1137: The automated tool detection lacks filtering for forks and test repositories.The
extract-tools-github.tsscript searches GitHub for all.asyncapi-toolmarker files using a raw code search query without any filtering. This causes personal forks, test repositories, and repositories with names like "testing", "fork", or "issue" to be included alongside legitimate AsyncAPI tools.To fix this, add filters to the GitHub search or post-extraction validation to exclude:
- Repositories marked as forks in GitHub's metadata
- Repository names containing "test", "testing", "fork", or similar patterns
- Non-organization repositories that duplicate official AsyncAPI tools
Examples in the current file:
Savio629/testing2,TahaShahid203/async-api-issue,hkirat/asyncapi-fork,WSOL12/html-template,dipaksodani/async-gen
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
config/all-tags.jsonconfig/tools-automated.jsonconfig/tools.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-01-19T04:51:41.255Z
Learnt from: anshgoyalevil
Repo: asyncapi/website PR: 3557
File: tests/fixtures/markdown/check-edit-links-data.js:3-11
Timestamp: 2025-01-19T04:51:41.255Z
Learning: In the AsyncAPI website repository, the test data in `tests/fixtures/markdown/check-edit-links-data.js` intentionally includes inconsistent paths (with and without 'docs' prefix) to verify the script's ability to normalize and handle ambiguous path structures.
Applied to files:
config/tools.json
📚 Learning: 2024-11-01T12:48:22.034Z
Learnt from: akshatnema
Repo: asyncapi/website PR: 3136
File: tests/fixtures/tools/automated-tools.json:8-9
Timestamp: 2024-11-01T12:48:22.034Z
Learning: In the `tests/fixtures/tools/automated-tools.json` file, the `language` field within the `filters` object can be either a string or an array. Both formats are acceptable and supported in the codebase.
Applied to files:
config/tools.json
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: cypress-run
- GitHub Check: Lighthouse CI
- GitHub Check: Test NodeJS PR - windows-latest
🔇 Additional comments (1)
config/all-tags.json (1)
215-319: Remove the semantic swap claims—they are factually incorrect.Tags are not swapped. In the
technologiessection, TypeScript and FastAPI appear sequentially at their respective lines, as do SmartPaste and JetBrains. However, the file does contain a genuine data quality issue: multiple tags are defined as duplicates (e.g., VSCode appears 2 times, SmartPaste appears 2 times, HTML appears 4 times). Additionally, many tags appear in both thelanguagesandtechnologiessections with different color values, which may cause inconsistent filtering behavior. Review and deduplicate the tags, and ensure consistent color definitions across sections.Likely an incorrect or invalid review comment.
2 participants
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.