Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg,
princerajpoot20 and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughConfiguration files underwent metadata reshuffling: languages and technologies lists swapped adjacent entries in Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5013 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from To Be Triaged
to Done
in Website - Kanban
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5013--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (6)
config/tools-automated.json (3)
349-405: Same issue: Multiple "AsyncAPI Studio" entries with test/fork repositories.Consistent with
tools.json, this file also contains three "AsyncAPI Studio" entries pointing to different repos. TheisAsyncAPIOwnerflags are correctly set (falsefor the test/fork repos,truefor the official one), but having these entries may still confuse users browsing the tools catalog.Consider removing entries that point to test repositories (
Shurtu-gal/action-test-bed,TahaShahid203/async-api-issue).
877-932: Same issue: Duplicate "asyncapi-preview" entries with test repository.Consistent with
tools.json:
- Line 881:
Savio629/testing2withisAsyncAPIOwner: false- Line 920:
asyncapi/vs-asyncapi-previewwithisAsyncAPIOwner: trueThe test repository entry should likely be removed.
1039-1090: Same issue: Multiple "HTML Template" entries with forks.Consistent with
tools.json:
- Line 1042:
WSOL12/html-templatewithisAsyncAPIOwner: false- Line 1060:
dipaksodani/async-genwithisAsyncAPIOwner: false- Line 1078:
asyncapi/html-templatewithisAsyncAPIOwner: trueThe fork entries should likely be removed to avoid confusion.
config/tools.json (3)
2700-2750: Remove duplicate "asyncapi-preview" entry pointing to test repository.The config contains two identical "asyncapi-preview" entries:
- Line 2701:
https://github.com/Savio629/testing2— appears to be a personal test repository- Line 2727:
https://github.com/asyncapi/vs-asyncapi-preview— the official repositoryThe first entry should be removed.
1348-1428: Remove duplicate "AsyncAPI Studio" entries pointing to unverifiable or non-official repositories.The code contains three separate entries all titled "AsyncAPI Studio" (lines 1349–1376, 1377–1404, 1405–1428) pointing to different repositories. Only
asyncapi/studiois the confirmed official repository; the other two URLs (Shurtu-gal/action-test-bedandTahaShahid203/async-api-issue) are not publicly discoverable and cannot be verified as legitimate tool entries. The entries with unverifiable repositories also havedescription: null, further suggesting they should not be in the tools listing.Keep only the official
asyncapi/studioentry and remove the duplicate entries to avoid user confusion.
2846-2924: Remove two unverified "HTML Template" entries from the AsyncAPI Generator Templates section.The file contains three "HTML Template" entries:
https://github.com/WSOL12/html-template(description: null)https://github.com/dipaksodani/async-gen(description: null)https://github.com/asyncapi/html-template(official template with description)The first two repositories cannot be verified to exist publicly or relate to AsyncAPI templates. Only the official
asyncapi/html-templateshould be listed.
🤖 Fix all issues with AI agents
In `@config/tools-automated.json`:
- Around line 786-821: There are two identical "AsyncAPI CLI" entries; remove or
disambiguate the forked entry that uses repoUrl
"https://github.com/hkirat/asyncapi-fork" (the one with "isAsyncAPIOwner":
false) to avoid confusing users—either delete that JSON object entirely or
modify its title/description to clearly mark it as a fork (e.g., append "(fork)"
and add notice in description), ensuring the official entry with repoUrl
"https://github.com/asyncapi/cli" and "isAsyncAPIOwner": true remains unchanged.
- Around line 516-548: The two GitHub Action entries are inconsistent: update
the "GitHub Action for Generator" entry (title "GitHub Action for Generator",
links.repoUrl, description, and filters.technology) so it correctly points to
the actual Generator action
(https://github.com/asyncapi/github-action-for-generator), set description to
describe the Generator action, and change filters.technology to "AsyncAPI
Generator" (or remove the entry if it is a duplicate of the CLI); for the
"GitHub Action for CLI" entry (title "GitHub Action for CLI") either add a
proper description and set links.repoUrl to the canonical action repo (or to
https://github.com/asyncapi/github-action-for-generator if that is intended) and
ensure filters.technology is "AsyncAPI CLI", or remove the entry if it
duplicates the CLI package — update only the fields links.repoUrl, description,
title, and filters.technology to resolve mismatches.
| "title": "GitHub Action for CLI", | ||
| "description": null, | ||
| "links": { | ||
| "repoUrl": "https://github.com/asyncapi/cli" | ||
| "repoUrl": "https://github.com/actions-marketplace-validations/asyncapi_github-action-for-generator" | ||
| }, | ||
| "filters": { | ||
| "technology": [ | ||
| "AsyncAPI Generator" | ||
| "AsyncAPI CLI" | ||
| ], | ||
| "categories": [ | ||
| "github-actions" | ||
| "github-action" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": true | ||
| "isAsyncAPIOwner": false | ||
| } | ||
| }, | ||
| { | ||
| "title": "GitHub Action for CLI", | ||
| "description": null, | ||
| "title": "GitHub Action for Generator", | ||
| "description": "CLI to work with your AsyncAPI files. You can validate them and in the future use a generator and even bootstrap a new file. Contributions are welcomed!", | ||
| "links": { | ||
| "repoUrl": "https://github.com/actions-marketplace-validations/asyncapi_github-action-for-generator" | ||
| "repoUrl": "https://github.com/asyncapi/cli" | ||
| }, | ||
| "filters": { | ||
| "technology": [ | ||
| "AsyncAPI CLI" | ||
| "AsyncAPI Generator" | ||
| ], | ||
| "categories": [ | ||
| "github-action" | ||
| "github-actions" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": false | ||
| "isAsyncAPIOwner": true | ||
| } | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# First, let's examine the config file to understand the entries better
echo "=== Config File Entries ==="
head -c 1000 config/tools-automated.json | tail -c 500
cat -n config/tools-automated.json | sed -n '516,548p'
echo ""
echo "=== Checking GitHub Links ==="
# Extract the repo URLs to understand what they point to
rg "actions-marketplace-validations|asyncapi/cli" config/tools-automated.json -B 5 -A 1Repository: asyncapi/website
Length of output: 3387
🌐 Web query:
asyncapi/cli repository github description
💡 Result:
The GitHub repository asyncapi/cli is described as:
“CLI to work with your AsyncAPI files. You can validate them and in the future use a generator and even bootstrap a new file. Contributions are welcomed!” [1]
Repo: https://github.com/asyncapi/cli [1]
🌐 Web query:
asyncapi github-action-for-generator repository
💡 Result:
The AsyncAPI GitHub Action for Generator repository is:
https://github.com/asyncapi/github-action-for-generator
It’s referenced in AsyncAPI’s GitHub Actions docs as uses: asyncapi/github-action-for-generator. [1], [2]
Fix title/description/URL mismatches in GitHub Action entries.
Entry "GitHub Action for Generator" (lines 533-547) has multiple inconsistencies:
- Title claims "GitHub Action for Generator" but the repository URL (
https://github.com/asyncapi/cli) points to the AsyncAPI CLI repo, not a Generator action - Description ("CLI to work with your AsyncAPI files...") describes the CLI tool, not a Generator action
- Technology is listed as "AsyncAPI Generator" but should be "AsyncAPI CLI"
- This entry duplicates the separate "AsyncAPI CLI" entry (lines ~549+) and should either be removed or corrected to point to the actual Generator action at
https://github.com/asyncapi/github-action-for-generator
Entry "GitHub Action for CLI" (lines 516-530) lacks a description and uses a marketplace-validation mirror URL. Verify if this should instead point directly to https://github.com/asyncapi/github-action-for-generator or if this entry should be removed entirely.
🤖 Prompt for AI Agents
In `@config/tools-automated.json` around lines 516 - 548, The two GitHub Action
entries are inconsistent: update the "GitHub Action for Generator" entry (title
"GitHub Action for Generator", links.repoUrl, description, and
filters.technology) so it correctly points to the actual Generator action
(https://github.com/asyncapi/github-action-for-generator), set description to
describe the Generator action, and change filters.technology to "AsyncAPI
Generator" (or remove the entry if it is a duplicate of the CLI); for the
"GitHub Action for CLI" entry (title "GitHub Action for CLI") either add a
proper description and set links.repoUrl to the canonical action repo (or to
https://github.com/asyncapi/github-action-for-generator if that is intended) and
ensure filters.technology is "AsyncAPI CLI", or remove the entry if it
duplicates the CLI package — update only the fields links.repoUrl, description,
title, and filters.technology to resolve mismatches.
| "title": "AsyncAPI CLI", | ||
| "description": "One CLI to rule them all. \nThis is a CLI that aims to integrate all AsyncAPI tools that you need while AsyncAPI document development and maintainance. \nYou can use it to generate docs or code, validate AsyncAPI document and event create new documents.\n", | ||
| "links": { | ||
| "websiteUrl": "https://zenwave360.github.io/", | ||
| "docsUrl": "https://zenwave360.github.io/zenwave-sdk/plugins/asyncapi-spring-cloud-streams3/", | ||
| "repoUrl": "https://github.com/zenwave360/zenwave-sdk" | ||
| "websiteUrl": "https://www.asyncapi.com/tools/cli", | ||
| "repoUrl": "https://github.com/asyncapi/cli" | ||
| }, | ||
| "filters": { | ||
| "language": "Java", | ||
| "technology": [ | ||
| "Maven", | ||
| "CLI", | ||
| "Spring Cloud Streams", | ||
| "JHipster JDL" | ||
| "TypeScript" | ||
| ], | ||
| "categories": [ | ||
| "code-generator", | ||
| "dsl", | ||
| "mocking-and-testing", | ||
| "others", | ||
| "cli" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": false | ||
| "isAsyncAPIOwner": true | ||
| } | ||
| }, | ||
| { | ||
| "title": "Mokapi", | ||
| "description": "Your API Mocking Tool for Agile Development. Mock and simulate AsyncAPI and OpenAPI services for local testing, development, and CI pipelines — with a visual dashboard to inspect your mocks and a powerful test data generator fully customizable with JavaScript.", | ||
| "title": "AsyncAPI CLI", | ||
| "description": "One CLI to rule them all. \nThis is a CLI that aims to integrate all AsyncAPI tools that you need while AsyncAPI document development and maintainance. \nYou can use it to generate docs or code, validate AsyncAPI document and event create new documents.\n", | ||
| "links": { | ||
| "websiteUrl": "https://mokapi.io", | ||
| "docsUrl": "https://mokapi.io/docs/guides/welcome", | ||
| "repoUrl": "https://github.com/marle3003/mokapi" | ||
| "websiteUrl": "https://www.asyncapi.com/tools/cli", | ||
| "repoUrl": "https://github.com/hkirat/asyncapi-fork" | ||
| }, | ||
| "filters": { | ||
| "language": "Go/Golang", | ||
| "technology": [ | ||
| "JavaScript", | ||
| "TypeScript", | ||
| "Docker" | ||
| "TypeScript" | ||
| ], | ||
| "categories": [ | ||
| "mocking-and-testing", | ||
| "others", | ||
| "cli" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": false | ||
| } |
There was a problem hiding this comment.
Duplicate AsyncAPI CLI entries - one official, one fork.
The CLIs section contains two "AsyncAPI CLI" entries with identical descriptions but different repositories:
- Lines 786-802: Official
asyncapi/cliwithisAsyncAPIOwner: true - Lines 805-821: Fork
hkirat/asyncapi-forkwithisAsyncAPIOwner: false
While the ownership flags correctly distinguish them, listing a fork with the same title and description alongside the official tool may confuse users. Consider whether the fork should be included in the catalog.
🤖 Prompt for AI Agents
In `@config/tools-automated.json` around lines 786 - 821, There are two identical
"AsyncAPI CLI" entries; remove or disambiguate the forked entry that uses
repoUrl "https://github.com/hkirat/asyncapi-fork" (the one with
"isAsyncAPIOwner": false) to avoid confusing users—either delete that JSON
object entirely or modify its title/description to clearly mark it as a fork
(e.g., append "(fork)" and add notice in description), ensuring the official
entry with repoUrl "https://github.com/asyncapi/cli" and "isAsyncAPIOwner": true
remains unchanged.
2 participants
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.