fix: add missing peer dependencies for build - #5648
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds ChangesRuntime dependencies
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
66-66: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPin the newly added dependency versions.
The lockfile currently resolves
@xyflow/reactto12.11.2andreact-i18nextto17.0.11, but the caret ranges allow future minor updates during lockfile regeneration. Use exact versions here to keep fresh builds reproducible.Proposed fix
- "`@xyflow/react`": "^12.11.2", + "`@xyflow/react`": "12.11.2", - "react-i18next": "^17.0.11", + "react-i18next": "17.0.11",Based on learnings, this repository prefers stable, well-tested dependency versions with exact pins or conservative ranges for reproducible builds.
Also applies to: 102-102
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` at line 66, Pin the newly added dependencies in package.json by replacing the caret ranges for `@xyflow/react` and react-i18next with exact versions matching the lockfile resolutions: 12.11.2 and 17.0.11.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package.json`:
- Line 66: Pin the newly added dependencies in package.json by replacing the
caret ranges for `@xyflow/react` and react-i18next with exact versions matching
the lockfile resolutions: 12.11.2 and 17.0.11.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 382629d6-c854-480a-affd-54a6a6dca984
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5648--asyncapi-website.netlify.app/ |
2 participants
Description:
This PR Fixes module resolution errors that caused fresh installations and builds to fail due to missing dependencies.
Changes:
react-i18next, which is required bynext-i18nextbut was not installed in the project dependencies.@xyflow/react, which is required by@tisoap/react-flow-smart-edge(a dependency ofschyma) for schema visualization.Before (build failing )
After (fixed)
Testing:
npm install✅npm run dev✅npm run build✅Related issue(s):
N/A
Summary by CodeRabbit