Skip to content

Route shadowed arguments typeof through unified bytecode - #2969

Merged
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-12
Jun 1, 2026
Merged

Route shadowed arguments typeof through unified bytecode#2969
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-12

Conversation

@rogeralsing

Copy link
Copy Markdown
Contributor

Summary

  • apply arguments binding-resolution to TypeOfIdentifier as well as normal reads
  • route typeof on parameter/lexical arguments through production unified bytecode
  • keep typeof on the implicit arguments object declined and documented

Verification

  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.TypeOfParameterNamedArguments_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.TypeOfImplicitArgumentsObject_DeclinesAndFallsBack|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.ParameterNamedArguments_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.LexicalArgumentsBinding_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_TypeOfParameterNamedArguments_AcceptsAsActivationSlot|FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_TypeOfImplicitArgumentsObject_DeclinesWithArgumentsDependency|FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_ArgumentsAccess_DeclinesWithArgumentsDependency|FullyQualifiedNameExpressionProgramCoverageMapTests.UnifiedBytecodeExpansionContract_ListsRequiredHeadingsAndCurrentEnums"
  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests|FullyQualifiedNameExpressionProgramCoverageMapTests.UnifiedBytecodeExpansionContract_ListsRequiredHeadingsAndCurrentEnums|FullyQualifiedName~UnifiedBytecodeProductionInvocationTests"
  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedName~ActivationSemanticsProofPackTests"
  • rtk rg "EvaluateExpression(|ProfileEvaluateExpression(" src/Asynkron.JsEngine/Ast/TypedAstEvaluator.ExecutionPlanRunner* (no matches)
  • rtk ./tools/profile forloop --memory (Total allocated 6.85 MB)
  • rtk git diff --check

Copilot AI review requested due to automatic review settings June 1, 2026 10:27
@rogeralsing
rogeralsing merged commit 0c8081b into main Jun 1, 2026
1 check failed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants