Skip to content

Sync property write decline docs - #2978

Merged
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-21
Jun 1, 2026
Merged

Sync property write decline docs#2978
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-21

Conversation

@rogeralsing

Copy link
Copy Markdown
Contributor

Summary

Verification

  • rtk rg -n "deeper compound|box.child.value += …|box.child.value &&= …|box[key+suffix]|logical-assignment operators,\s*$|computed-expression keys)" docs/unified-bytecode-expansion-contract.md docs/rules/unified-bytecode-prototypes.md docs/rules/expression-bytecode-assignment.md (no matches)
  • rtk git diff --check
  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedName~ExpressionProgramCoverageMapTests.UnifiedBytecodeExpansionContract_ListsRequiredHeadingsAndCurrentEnums" (1 passed; 7 unrelated existing nullable warnings in test files)

Copilot AI review requested due to automatic review settings June 1, 2026 12:45
@rogeralsing
rogeralsing merged commit a710387 into main Jun 1, 2026
@rogeralsing
rogeralsing deleted the codex/unified-bytecode-loop-21 branch June 1, 2026 12:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates unified-bytecode documentation to reflect recently widened support for nested named compound/logical property writes and direct computed expression-key assignments, and to remove now-stale “retained decline” examples so the contract/rules stay current with the production boundary.

Changes:

  • Refreshes the production property-write boundary text in docs/unified-bytecode-expansion-contract.md (nested named compound/logical/update admission; computed-expression-key neighbors remain declined).
  • Updates durable rule guidance in docs/rules/unified-bytecode-prototypes.md to reflect the expanded nested named receiver routing and computed expression-key assignment support.
  • Tightens the “update boundary docs when admitting shapes” rule in docs/rules/expression-bytecode-assignment.md to discourage carrying forward stale decline examples.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/unified-bytecode-expansion-contract.md Removes stale retained-decline examples and clarifies current admission/decline boundaries for nested named writes and computed expression-key assignment.
docs/rules/unified-bytecode-prototypes.md Updates the durable “nested named receiver writes” rule to reflect newly admitted shapes and clarify what remains declined.
docs/rules/expression-bytecode-assignment.md Updates durable guidance to require boundary docs stay aligned with newly admitted property-write shapes and current declines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +325 to +329
payload. Direct computed assignments may also route with a supported
computed-key expression span and simple RHS, for example
`box[key + suffix] = y`. Do not infer that computed-expression-key
compound/logical/update neighbors, optional chains, `super`, private names,
calls, dynamic lookup, or unsupported RHS/key spans are covered by the same
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants