Sync property write decline docs - #2978
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates unified-bytecode documentation to reflect recently widened support for nested named compound/logical property writes and direct computed expression-key assignments, and to remove now-stale “retained decline” examples so the contract/rules stay current with the production boundary.
Changes:
- Refreshes the production property-write boundary text in
docs/unified-bytecode-expansion-contract.md(nested named compound/logical/update admission; computed-expression-key neighbors remain declined). - Updates durable rule guidance in
docs/rules/unified-bytecode-prototypes.mdto reflect the expanded nested named receiver routing and computed expression-key assignment support. - Tightens the “update boundary docs when admitting shapes” rule in
docs/rules/expression-bytecode-assignment.mdto discourage carrying forward stale decline examples.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/unified-bytecode-expansion-contract.md | Removes stale retained-decline examples and clarifies current admission/decline boundaries for nested named writes and computed expression-key assignment. |
| docs/rules/unified-bytecode-prototypes.md | Updates the durable “nested named receiver writes” rule to reflect newly admitted shapes and clarify what remains declined. |
| docs/rules/expression-bytecode-assignment.md | Updates durable guidance to require boundary docs stay aligned with newly admitted property-write shapes and current declines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+325
to
+329
| payload. Direct computed assignments may also route with a supported | ||
| computed-key expression span and simple RHS, for example | ||
| `box[key + suffix] = y`. Do not infer that computed-expression-key | ||
| compound/logical/update neighbors, optional chains, `super`, private names, | ||
| calls, dynamic lookup, or unsupported RHS/key spans are covered by the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification