Skip to content

Close stale unified bytecode lowering gates - #2982

Merged
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-25
Jun 1, 2026
Merged

Close stale unified bytecode lowering gates#2982
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-25

Conversation

@rogeralsing

Copy link
Copy Markdown
Contributor

Summary

  • lower VM-owned property set/update ops and SwapTopTwo through the general expression loop
  • align resumable eligibility with the opcodes ExecuteResumable already implements
  • add drift audits for general expression lowering gaps and resumable opcode allow-list coverage

Verification

  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter 'FullyQualifiedNameExpressionProgramCoverageMapTests|FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.EvaluateResumable_ShortCircuitReturnExpression_AcceptsImplementedVmOpcodes'
  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter 'FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests|FullyQualifiedNameExpressionProgramCoverageMapTests'
  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter 'FullyQualifiedName~UnifiedBytecodeProductionInvocationTests'
  • rtk dotnet build src/Asynkron.JsEngine/Asynkron.JsEngine.csproj -c Release
  • rtk git diff --check
  • rtk rg 'EvaluateExpression(|ProfileEvaluateExpression(' src/Asynkron.JsEngine/Ast/TypedAstEvaluator.ExecutionPlanRunner*
  • rtk ./tools/profile forloop --memory

Copilot AI review requested due to automatic review settings June 1, 2026 13:44
@rogeralsing
rogeralsing merged commit b5f793e into main Jun 1, 2026
@rogeralsing
rogeralsing deleted the codex/unified-bytecode-loop-25 branch June 1, 2026 13:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants