Skip to content

Route private named writes through unified bytecode - #2997

Merged
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-39-private-write
Jun 1, 2026
Merged

Route private named writes through unified bytecode#2997
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-39-private-write

Conversation

@rogeralsing

Copy link
Copy Markdown
Contributor

Summary

  • admit direct first-boundary private named property writes into production unified bytecode
  • let SetNamedProperty resolve private PropertyHandle instances in the VM
  • update the expansion contract and add eligibility/invocation coverage while keeping private updates/deletes declined

Verification

  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.PrivateNamedPropertyWrite_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.PrivateNamedPropertyRead_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_PrivateNamedPropertyWrite_AcceptsNamedPropertyOpcode|FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_PrivateNamedPropertyUpdate_DeclinesWithExplicitCode|FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_PrivateNamedPropertyDelete_DeclinesWithExplicitCode|FullyQualifiedNameExpressionProgramCoverageMapTests.UnifiedBytecodeExpansionContract_ListsRequiredHeadingsAndCurrentEnums"
  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests|FullyQualifiedNameUnifiedBytecodeProductionConstructCallTests|FullyQualifiedNameExpressionProgramCoverageMapTests"
  • rtk dotnet build src/Asynkron.JsEngine/Asynkron.JsEngine.csproj -c Release
  • rtk rg "EvaluateExpression(|ProfileEvaluateExpression(" src/Asynkron.JsEngine/Ast/TypedAstEvaluator.ExecutionPlanRunner*
  • rtk git diff --check

Copilot AI review requested due to automatic review settings June 1, 2026 18:27
@rogeralsing
rogeralsing merged commit e79c278 into main Jun 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rogeralsing
rogeralsing deleted the codex/unified-bytecode-loop-39-private-write branch June 1, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants