Skip to content

Admit rich computed delete keys in unified bytecode - #3003

Merged
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-43-rich-delete-key
Jun 1, 2026
Merged

Admit rich computed delete keys in unified bytecode#3003
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-43-rich-delete-key

Conversation

@rogeralsing

Copy link
Copy Markdown
Contributor

Summary

  • admit computed property deletes with supported multi-op key spans, e.g. delete box.child[left + right]
  • keep unresolved computed delete keys declined as DynamicLookupDependency
  • update the unified bytecode contract and production tests for the widened delete lane

Tests

  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_NestedComputedPropertyDeleteRichKeyCandidate_AcceptsOwnedPropertyOpcodes|FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_NestedComputedPropertyDeleteUnsupportedKey_DeclinesBeforeVm|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.NestedNamedReceiverComputedPropertyDeleteRichKey_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.NestedNamedReceiverComputedPropertyDelete_UsesUnifiedBytecodeProductionFastPathAndKeySemantics|FullyQualifiedName~ExpressionProgramCoverageMapTests.UnifiedBytecodeExpansionContract_ListsRequiredHeadingsAndCurrentEnums"
  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests|FullyQualifiedNameExpressionProgramLoweringTests|FullyQualifiedNameExpressionProgramCoverageMapTests|FullyQualifiedName~DeleteOperatorTests"
  • rtk dotnet build src/Asynkron.JsEngine/Asynkron.JsEngine.csproj -c Release
  • rtk rg "EvaluateExpression(|ProfileEvaluateExpression(" src/Asynkron.JsEngine/Ast/TypedAstEvaluator.ExecutionPlanRunner*
  • rtk git diff --check

Copilot AI review requested due to automatic review settings June 1, 2026 19:53
@rogeralsing
rogeralsing merged commit 50be579 into main Jun 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rogeralsing
rogeralsing deleted the codex/unified-bytecode-loop-43-rich-delete-key branch June 1, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants