Skip to content

Admit optional computed spread calls - #3005

Merged
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-45-optional-computed-spread-call
Jun 1, 2026
Merged

Admit optional computed spread calls#3005
rogeralsing merged 1 commit into
mainfrom
codex/unified-bytecode-loop-45-optional-computed-spread-call

Conversation

@rogeralsing

Copy link
Copy Markdown
Contributor

Summary

  • admit optional-start computed member spread calls such as a?.boxkey
  • use the existing spread-mask call boundary for the optional computed call path
  • update the production eligibility/runtime proofs and bytecode expansion contract

Tests

  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests.Evaluate_OptionalChainComputedPlainSpreadCallExpressionPlan_AcceptsExecutableInvocationBoundary|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests.OptionalChainComputedPlainSpreadCall_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameUnifiedBytecodeProductionSpreadCallTests|FullyQualifiedNameExpressionProgramLoweringTests.ReturnInstruction_SpreadCallExpression_IsLoweredToExpressionProgram|FullyQualifiedName~ExpressionProgramCoverageMapTests.UnifiedBytecodeExpansionContract_ListsRequiredHeadingsAndCurrentEnums"
  • rtk dotnet test tests/Asynkron.JsEngine.Tests -c Release --filter "FullyQualifiedNameUnifiedBytecodeProductionEligibilityTests|FullyQualifiedNameUnifiedBytecodeProductionInvocationTests|FullyQualifiedNameUnifiedBytecodeProductionSpreadCallTests|FullyQualifiedNameExpressionProgramLoweringTests|FullyQualifiedNameExpressionProgramCoverageMapTests|FullyQualifiedNameAstFreeExecutionAssertionTests"
  • rtk dotnet build src/Asynkron.JsEngine/Asynkron.JsEngine.csproj -c Release
  • rtk rg "EvaluateExpression(|ProfileEvaluateExpression(" src/Asynkron.JsEngine/Ast/TypedAstEvaluator.ExecutionPlanRunner*
  • rtk git diff --check

Copilot AI review requested due to automatic review settings June 1, 2026 20:07
@rogeralsing
rogeralsing merged commit c7f5f17 into main Jun 1, 2026
1 check failed
@rogeralsing
rogeralsing deleted the codex/unified-bytecode-loop-45-optional-computed-spread-call branch June 1, 2026 20:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants