Fix: Create child environment for IR script execution - #552
Closed
rogeralsing with Copilot wants to merge 5 commits into
Closed
Fix: Create child environment for IR script execution#552rogeralsing with Copilot wants to merge 5 commits into
rogeralsing with Copilot wants to merge 5 commits into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: rogeralsing <647031+rogeralsing@users.noreply.github.com>
Co-authored-by: rogeralsing <647031+rogeralsing@users.noreply.github.com>
Co-authored-by: rogeralsing <647031+rogeralsing@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix create child environment for IR script execution
Fix: Create child environment for IR script execution
Jan 9, 2026
Contributor
|
@copilot build fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
IR script execution was overwriting GlobalEnvironment's slot 0 (Symbol.This → GlobalObject) with synthetic slots for loop iterators, causing global identifier resolution to fail with ReferenceError instead of the expected TypeError.
Solution
Create a child environment for IR synthetic slots when the parent environment already has slots:
Benefits over offset-based approach:
Changes:
TypedAstEvaluator.ExecutionPlanRunner.Core.cs: Child environment creation logicDebugScopeTests.csOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.