xpadneo, rumble: Properly save and restore IRQ state during locking

A previous refactor to scoped guards accidentally changed locking
semantics from `spinlock_irqsave/irqrestore` to `spinlock_irq`.

With `spinlock_irq`, IRQs are unconditionally enabled on unlock.
In this path that can re-enable IRQs too early while outer input/FF
locking still expects them disabled, allowing ff-memless timer re-entry
and resulting in a hard lockup.

Switch rumble locking to `spinlock_irqsave` so the previous IRQ state
is restored correctly.

Reported hard lockup trace (excerpt):
  watchdog: CPU6: Watchdog detected hard LOCKUP on cpu 6
  _raw_spin_lock_irqsave+0x3d/0x50
  input_event+0x41/0x90
  xpadneo_events_event+0x225/0x350 [hid_xpadneo]

Fixes: ee5c0d4 ("xpadneo, rumble: Migrate to more modern scoped locks")
Fixes: #596
Signed-off-by: Kai Krakow <kai@kaishome.de>

Author: kakra

hid-xpadneo/src/xpadneo/rumble.c

@@ -83,7 +83,7 @@ static void rumble_worker(struct work_struct *work)
 		r->data.loop_count = 0xEB;
 	}
 
-	scoped_guard(spinlock_irq, &xdata->rumble.lock) {
+	scoped_guard(spinlock_irqsave, &xdata->rumble.lock) {
 
 		/* let our scheduler know we've been called */
 		xdata->rumble.scheduled = false;
@@ -143,7 +143,7 @@ static void rumble_worker(struct work_struct *work)
 	 * throttle next command submission, the firmware doesn't like us to
 	 * send rumble data any faster
 	 */
-	scoped_guard(spinlock_irq, &xdata->rumble.lock) {
+	scoped_guard(spinlock_irqsave, &xdata->rumble.lock) {
 		xdata->rumble.throttle_until = RUMBLE_THROTTLE_JIFFIES;
 		if (xdata->rumble.scheduled) {
 			unsigned long delay_work = calculate_throttling_delay(xdata);
@@ -205,7 +205,7 @@ static int rumble_play(struct input_dev *dev, void *data, struct ff_effect *effe
 	 */
 	max_main = max(weak, strong);
 
-	scoped_guard(spinlock_irq, &xdata->rumble.lock) {
+	scoped_guard(spinlock_irqsave, &xdata->rumble.lock) {
 		unsigned long delay_work;
 
 		/* calculate the physical magnitudes, scale from 16 bit to 0..100 */