Skip to content

WIP: xpadneo, device: Fix up NUL byte before final End Collection #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kakra wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: xpadneo, device: Fix up NUL byte before final End Collection #622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions hid-xpadneo/src/xpadneo/device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,17 @@ const __u8 *xpadneo_device_report_fixup(struct hid_device *hdev, __u8 *rdesc, un
if (*rsize >= 2 && rdesc[*rsize - 2] == 0xC0 && rdesc[*rsize - 1] == 0x00) {
hid_notice(hdev, "fixing up report descriptor size\n");
*rsize -= 1;
} else if (*rsize >= 2 && rdesc[*rsize - 2] == 0x00 && rdesc[*rsize - 1] == 0xC0) {
/*
* Some firmwares write 0x00 where a second End Collection
* (0xC0) was needed, followed by a correct final 0xC0.
* Replace the 0x00 with 0xC0 so the descriptor ends with two
* End Collections. Do NOT shrink the descriptor: both bytes
* are valid End Collection items and are needed to close the
* two open collections.
*/
hid_notice(hdev, "fixing up report descriptor NUL before end collection\n");
rdesc[*rsize - 2] = 0xC0;
}

/* fixup reported axes for Xbox One S */
Expand Down