Use TryAdd when registering services + add EventStreamId ctor #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 10, 2025 11:10
Prevents `string[] parts` allocation, and subsequent `string.Join()`
registrations. Similarly to AddEventStore().
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Atc.Cosmos.EventStore.Cqrs/EventStreamId.cs:16
- The main constructor does not assign the 'Parts' property, which is expected to be equivalent to the input 'parts'. Consider initializing 'Parts' (e.g., this.Parts = parts) to ensure that the test 'Parts_property_must_return_parts' passes.
public EventStreamId(params string[] parts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
UseCQRS()method does not use TryAdd when registering services - like theAddEventStore()does. This means duplicate registrations whenUseCQRS()are invoked multiple time.Also add a ctor on
EventStreamIdthat allow cheaper "cloning" of an existingEventStreamId- preventsparams string[] partsallocation, and subsequentstring.Join().