Release DeletePartitionAsync #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.net 9 introduces a lot of new warnings that will fail the build. An effort is required to upgrade to .net 9 and resolve or ignore relevant warnings
Newtonsoft now needs to be references explicitly in order to build due to breaking change in version 3.46.0 of the Cosmos SDK
TomMalow
force-pushed
the
feature/release-delete-partition
branch
from
6ef96dc to
2cc393a
Compare
LarsSkovslund
approved these changes
Dec 9, 2024
Contributor
LarsSkovslund
left a comment
LarsSkovslund
left a comment
There was a problem hiding this comment.
Looks good, thanks for contributing @TomMalow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of Cosmos SDK version 3.45.0 the
DeleteAllItemsByPartitionKeyStreamAsyncis globally available which means that theICosmosWriter.DeletePartitionAsyncno longer needs to be part of the preview flag.As part of the upgrade of the Cosmos SDK 3.46.0 introduced a breaking change where consumers needs to explicitly reference Newtonsoft.
In addition, the repo is set to target .net8 to postpone handling warnings introduces as part of .net 9