Skip to content

Conversation

@lfarv
Copy link
Contributor

@lfarv lfarv commented Apr 14, 2025

It's more than time to issue new releases of AT and PyAT.

For this, we should look at pending pull requests:

3 are waiting approval:

It would be nice to get approval for these

2 are "active" drafts:

Should we wait for these or postpone them to the next release?

3 are currently asleep:

@lfarv lfarv added enhancement Matlab For Matlab/Octave AT code Python For python AT code labels Apr 14, 2025
@lcarver
Copy link
Contributor

lcarver commented Apr 15, 2025

I will finish off the beam loading branch to try and get it merged (but i have easter holidays coming soon so will try to get it done before then).

@swhite2401
Copy link
Contributor

@lfarv, I will free some time to review the pending PRs

Concerning the active drafts:

  • I have been using the matching extensively and we can merge that version, I am not excluding further suggestions. On e question though, where do we stand with this parameters class, I am now running into a case where I have to create a lot of observables to match a lattice which is rather painful.... the parameters class that was proposed at some point would be extremely useful.
  • For the rotate element function I have no strong opinion, up to you.

Finally for stale branches, I think they either need more discussion or significant development, no need to rush on these.

@SebastienJoly
Copy link
Collaborator

For the element rotation branch, I think it does not require a lot of work before being ready. I will try to finish it as soon as possible.

@lfarv
Copy link
Contributor Author

lfarv commented Apr 17, 2025

About versioning for this new release:

Should we switch to the new matching method: if so, we should change the major version number to report some changes breaking the compatibility. Therefore the python version would be 1.0.0. This also needs some reorganisation of modules, moving the old matching to a "deprecated" module (not imported by default), and moving the new matching into standard.

Otherwise, we can postpone the new matching to the next release and keep the version number at 0.7.0.

I would push for jumping to 1.0.0.

@swhite2401
Copy link
Contributor

@lfarv, can we keep the new matching for future release? I think I am the only one that did the transition. At least let's first check with @simoneliuzzo if this is ok

@lfarv
Copy link
Contributor Author

lfarv commented Apr 18, 2025

can we keep the new matching for future release

Ok, no problem. I'll add a word on that in the release notes.

@lfarv
Copy link
Contributor Author

lfarv commented Apr 18, 2025

@swhite2401

where do we stand with this parameters class

I'll start again on that, and try the idea you proposed here.

@lfarv
Copy link
Contributor Author

lfarv commented Apr 21, 2025

can we keep the new matching for future release?

Concerning the matching:

  • we keep the old one by default, but
  • I added a line in the release notes stating that the present matching will be deprecated in a future release, and suggesting to switch from now on to the new one.
  • I added a line in the documentation of at/matching/matching.py (old one) saying that it is now obsolete, with links to the new variables, observables and matching,
  • I added an example notebook showing the use of the new matching. The example is taken from the test modules, it's not optimum. A better example is welcome!

All this can be checked here. It should help the transition.

@lfarv lfarv force-pushed the release_0.7_2.7 branch from 2183cfe to c6af9d7 Compare April 28, 2025 09:55
@lfarv
Copy link
Contributor Author

lfarv commented May 12, 2025

@swhite2401, @SebastienJoly, @oscarxblanco, @simoneliuzzo
I think that we are now ready for new releases of AT and PyAT. Unless you suggest another modification… Please have a look at the release notes and decide.

@oscarxblanco
Copy link
Contributor

@lfarv I think this is OK to release.

@SebastienJoly
Copy link
Collaborator

@lfarv Good for me as well

@lfarv lfarv merged commit 6d10a82 into master Jun 2, 2025
28 checks passed
@lfarv lfarv deleted the release_0.7_2.7 branch June 2, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Matlab For Matlab/Octave AT code Python For python AT code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants