Skip to content

Filter old events in admin#67

Open
KasperNurminen wants to merge 1 commit intootax/productionfrom
feature/hide-old-events-in-admin
Open

Filter old events in admin#67
KasperNurminen wants to merge 1 commit intootax/productionfrom
feature/hide-old-events-in-admin

Conversation

@KasperNurminen
Copy link
Copy Markdown
Member

Now all events in the history of ilmomasiina are displayed. Should probably remove events over 1 month old, for example

@Jonesus
Copy link
Copy Markdown
Contributor

Jonesus commented Sep 11, 2019

At some point I feel it might be beneficial to be able to view all old events in the admin UI, maybe with pagination or something

@KasperNurminen
Copy link
Copy Markdown
Member Author

Don't know how well sequelize/feathers support pagination, what's the use case for viewing very old events? I am just not sure if it is really worth the development effort

@Jonesus
Copy link
Copy Markdown
Contributor

Jonesus commented Sep 11, 2019

I was mostly considering it from the viewpoint of feature parity with the super legacy php ilmomasiina, I think the full event history from ilmomasiina has been used a couple of times for guild magazine articles, guild history book and IE event statistics, it is true that it's not a high priority feature by any means

@peksi
Copy link
Copy Markdown
Collaborator

peksi commented Sep 11, 2019

We need to solve #68 before pagination functions correctly.

Feathers uses $limit=n and $skip=n for paginating items in api listing

@peksi
Copy link
Copy Markdown
Collaborator

peksi commented Oct 9, 2019

I wouldn't put this into production before we have the pagination working

leevironty referenced this pull request in fyysikkokilta/ilmomasiina Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants