Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
211d6d2
ci: guard the no-conditional-shell rule for run: blocks with a ratche…
cmgrote Nov 4, 2026
f5a3cfc
ci: move check-dapr-version's branching into a tested script
cmgrote Nov 4, 2026
b1f6db9
ci: move sdr-e2e's branching into tested scripts and keep one repin s…
cmgrote Nov 4, 2026
434662a
ci: move build-and-publish-app's branching into tested scripts
cmgrote Nov 4, 2026
e4b0b6d
fix(ci): address lens round-1 findings on the conditional-shell migra…
cmgrote Nov 4, 2026
88e9a66
test(ci): check argv for the webhook's secret path, not its host
cmgrote Nov 4, 2026
acfe408
fix(ci): fail the certify gate closed when an app's dependencies do n…
cmgrote Nov 4, 2026
9acead9
fix(ci): contract-drift gate fails closed without poe and checks the …
cmgrote Nov 5, 2026
2f288d2
Merge remote-tracking branch 'origin/main' into FND-4244
cmgrote Nov 5, 2026
8c77ec8
ci: keep the new CI scripts and tests clean under the pyright baseline
cmgrote Nov 5, 2026
5e910c0
ci: certify contract drift regenerates with the SDK, not the app's po…
cmgrote Nov 5, 2026
36733c2
ci: keep the GitHub token out of app code in the certify gate [FND-47…
cmgrote Nov 5, 2026
0daf927
ci: keep the GitHub token out of app code in the CI reusables [FND-47…
cmgrote Nov 5, 2026
7f661c7
ci: mint a read-only App token for the image build's git_token secret…
cmgrote Nov 6, 2026
fcd31ea
Merge branch 'main' into christophergrote/fnd-4244
cmgrote Nov 6, 2026
5b9b967
ci: keep the private-dependency token out of uv and build backends, a…
cmgrote Nov 6, 2026
6e98694
ci: hold the private-dependency token in a mirror-only step, and inli…
cmgrote Nov 6, 2026
21bbd0a
test(ci): keep the endor checkout test under the pyright baseline
cmgrote Nov 6, 2026
4f69f82
ci: cap the private-dependency token at an SDK-reviewed allowlist
cmgrote Nov 6, 2026
614ae2f
ci: state the allowlist cap at each private-dependency token mint
cmgrote Nov 6, 2026
0c8e21d
Merge remote-tracking branch 'origin/main' into FND-4244
cmgrote Nov 9, 2026
57e37fb
ci: say why the SDK helper checkouts need no token
cmgrote Nov 9, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/actionlint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ paths:
.github/workflows/test-commands-reusable.yaml:
ignore:
- 'property "workflow_sha" is not defined'
# The scoped private-dependency token mint's git_auth.py checkout (lens
# round 5 on #4731): the `repos` step runs before a token exists, from the
# workflow's own commit.
.github/workflows/release-version-bump.yaml:
ignore:
- 'property "workflow_sha" is not defined'

# FALSE POSITIVE — deliberate kill switch, not dead code left by accident.
# The job body and its input are retained on purpose so callers that still
Expand All @@ -97,3 +103,6 @@ paths:
.github/workflows/build-and-publish-app.yaml:
ignore:
- 'constant expression "false" in condition'
# job.workflow_sha: see the FALSE POSITIVE block above (the scoped
# private-dependency token mint's git_auth.py checkout).
- 'property "workflow_sha" is not defined'
7 changes: 3 additions & 4 deletions .github/actions/build-app-image/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -164,16 +164,15 @@ runs:
# The script is shared from the sibling action rather than copied a third
# time. Reaching across action dirs with `../` is the established pattern
# here (see connector-unit-tests/action.yaml, which reads
# connector-integration-tests' copy the same way). Note there are already
# two byte-identical copies of this script in the repo; consolidating them
# is worth doing, but not as a side effect of this change.
# connector-integration-tests' copy the same way). That copy is the only
# one; sdr-e2e stashes it too.
- name: Pin application-sdk to dispatched ref (pre-build)
if: inputs.application-sdk-ref != ''
shell: bash
env:
SDK_REF: ${{ inputs.application-sdk-ref }}
run: |
"${{ github.action_path }}/../sdr-e2e/repin-application-sdk.sh"
"${{ github.action_path }}/../connector-integration-tests/repin-application-sdk.sh"
if ! command -v uv >/dev/null 2>&1; then
echo "Installing uv for the pre-build re-lock..."
"${{ github.action_path }}/../../scripts/with-retry.sh" \
Expand Down
12 changes: 11 additions & 1 deletion .github/actions/connector-integration-tests/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -214,13 +214,23 @@ inputs:
required: false
default: ""

git-auth-token:
required: false
description: |
Read-only GitHub token for a PRIVATE atlanhq git dependency, passed to
setup-deps and to the SDK repin's `uv sync`, each through
`.github/scripts/git_auth.py` so no git config is written (FND-4740).
Empty (the default) installs without one.
default: ""

runs:
using: "composite"
steps:
- name: Setup Python, uv, and dependencies
uses: atlanhq/application-sdk/.github/actions/setup-deps@main
with:
python-version: ${{ inputs.python-version }}
git-auth-token: ${{ inputs.git-auth-token }}

- name: Pin application-sdk to dispatched ref
if: inputs.application-sdk-ref != ''
Expand All @@ -230,7 +240,7 @@ runs:
run: |
chmod +x "${{ github.action_path }}/repin-application-sdk.sh"
"${{ github.action_path }}/repin-application-sdk.sh"
uv sync --all-extras --all-groups
python3 "${{ github.action_path }}/../../scripts/git_auth.py" run -- uv sync --all-extras --all-groups

# Regenerate app/generated/** (incl. manifest.json — the AE DAG) from
# contract/app.pkl before the app server boots, so the host harness exercises
Expand Down
12 changes: 11 additions & 1 deletion .github/actions/connector-unit-tests/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,23 @@ inputs:
review too — parity with connector-integration-tests.
default: ""

git-auth-token:
required: false
description: |
Read-only GitHub token for a PRIVATE atlanhq git dependency, passed to
setup-deps and to the SDK repin's `uv sync`, each through
`.github/scripts/git_auth.py` so no git config is written (FND-4740).
Empty (the default) installs without one.
default: ""

runs:
using: "composite"
steps:
- name: Setup Python, uv, and dependencies
uses: atlanhq/application-sdk/.github/actions/setup-deps@main
with:
python-version: ${{ inputs.python-version }}
git-auth-token: ${{ inputs.git-auth-token }}

- name: Pin application-sdk to dispatched ref
if: inputs.application-sdk-ref != ''
Expand All @@ -73,7 +83,7 @@ runs:
REPIN="${{ github.action_path }}/../connector-integration-tests/repin-application-sdk.sh"
chmod +x "$REPIN"
"$REPIN"
uv sync --all-extras --all-groups
python3 "${{ github.action_path }}/../../scripts/git_auth.py" run -- uv sync --all-extras --all-groups

- name: Run unit tests with coverage
id: tests
Expand Down
Loading
Loading