Repository navigation
fix(ci): contract-drift gate fails closed without poe and checks the whole working tree [FND-4539, FND-4700] - #4736
Merged
Conversation
…kl has no poe certify.py contract-drift used to warn and pass when contract/app.pkl existed but 'uv run poe' was unavailable, so a publish-blocking gate silently skipped. It now fails with an error that names the fix: poethepoet in an extra (certify installs with --all-extras, not groups), a [tool.poe.tasks] generate task, and a re-lock. Claude-Session: https://claude.ai/code/session_01AbKqGZj6E9KZuRVMzPpMwt
cmgrote
requested review from
Aryamanz29,
OnkarVO7,
atlan-ci and
vaibhavatlan
as code owners
November 4, 2026 09:55
… untracked output [FND-4700] (#4757)
…fnd-4539-sync # Conflicts: # .github/scripts/build_and_publish/certify.py # docs/standards/app-certification.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FND-4539 and FND-4700 (#4757 squashed in). Stacked on #4731 (base
christophergrote/fnd-4244). Retarget tomainonce #4731 merges. Do not merge: 20 apps would be blocked from publishing (see below).What changes
certify.py contract-driftis an enforced publish gate. It had two holes, and both are closed incontract_drift().verdictis untouched; FND-4538 (#4738) edits it and is merged into this branch.1. No poe → fail, not pass (FND-4539). When
contract/app.pklexisted butuv run poewas unavailable, the gate logged::warning::and passed. Now it fails with::error::. The message names the fix:poethepoetto an extra in[project.optional-dependencies]. Certify installs withuv sync --all-extras --frozen, so a[dependency-groups]entry is not installed.[tool.poe.tasks]generatetask (canonical shape: atlan-mysql-app).2. Whole-tree stale check (FND-4700). The stale check was
git diff --exit-code -- generated/from the app root, which missed two things:generated/, notapp/generated/or root files likeatlan.yaml.git diffignores untracked output.After
poe generate, the gate now fails whengit status --porcelain --untracked-files=allis non-empty. The::error::lists the paths (capped at 50), never their contents. Gitignored files don't count.Apps without
contract/app.pklstill skip.docs/standards/app-certification.mdcovers both rules.Verification
pytestontest_build_and_publish_certify.py,test_build_and_publish_certify_wiring.pyandtest_certify_unit_shards.py: 78 passed. These include the merged-in fix(ci): fail the certify gate closed when an app's dependencies do not install #4738.certify.py, the 2 new assertions fail.uv run. Against the pre-FND-4700certify.py, 6 fail, including a stale trackedapp/generated/file, an untracked new file, and a rootatlan.yamlchange. On the fix, all pass.Blast radius
No poe: 6 apps (checked 2026-11-04 on each default branch)
Whole tree: 106 caller apps with
contract/app.pkl(measured 2026-11-04)Each app was run locally through certify's steps (
uv sync --all-extras --frozen→poe generate→ whole-tree status), with uv user config disabled to match CI. The old check passes all of them.uv.lock.pydiffers only by import order or line wrapping, because the toolkit's output isn't ruff-stable and app pre-commit reformats the committed copyatlan.yaml), notification (manifest.json), powerbi (app/contracts/*)poe generateleaves the tree cleanThe per-app list is on FND-4700.
Merge order
🤖 Generated with Claude Code
https://claude.ai/code/session_01AbKqGboFK2UACRjz2eg4FV