DG-1924 | Add 'assetsCountToPropagate' and 'assetsCountPropagated' in task vertex. #4032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeet-atlan
requested review from
Madusudanan,
hr2904,
jnkrmg,
nikhilbonte21 and
sumandas0
abhijeet-atlan
force-pushed
the
tagpropv1master
branch
3 times, most recently
from
bc0322a to
cd6f2a3
Compare
jnkrmg
requested changes
Jan 28, 2025
...itory/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
Show resolved
Hide resolved
abhijeet-atlan
force-pushed
the
tagpropv1master
branch
from
e3485d8 to
a118278
Compare
sumandas0
reviewed
Jan 28, 2025
abhijeet-atlan
force-pushed
the
tagpropv1master
branch
2 times, most recently
from
2ea2057 to
7ff6994
Compare
abhijeet-atlan
force-pushed
the
tagpropv1master
branch
from
ed9f39a to
398085d
Compare
hr2904
suggested changes
Jan 28, 2025
intg/src/main/java/org/apache/atlas/model/patches/AtlasPatch.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchRegistry.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Outdated
Show resolved
Hide resolved
sumandas0
reviewed
Jan 30, 2025
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Outdated
Show resolved
Hide resolved
| //update the 'assetsCountToPropagate' in the current task vertex. | ||
| AtlasVertex currentTaskVertex = (AtlasVertex) graph.query().has(TASK_GUID, currentTask.getGuid()).vertices().iterator().next(); | ||
| currentTaskVertex.setProperty(TASK_ASSET_COUNT_TO_PROPAGATE, currentTask.getAssetsCountToPropagate()); | ||
| graph.commit(); |
Author
There was a problem hiding this comment.
Wrote a new function updateTaskVertexProperty that is used everywhere and it doesn't have graph.commit() in it.
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Outdated
Show resolved
Hide resolved
...itory/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
Show resolved
Hide resolved
| List<AtlasGraphQuery> orConditions = new LinkedList<>(); | ||
| orConditions.add(query.createChildQuery().has(Constants.TASK_STATUS, AtlasTask.Status.IN_PROGRESS)); | ||
| orConditions.add(query.createChildQuery().has(Constants.TASK_STATUS, AtlasTask.Status.PENDING)); | ||
| orConditions.add(query.createChildQuery().has(TASK_STATUS, AtlasTask.Status.IN_PROGRESS)); |
Author
There was a problem hiding this comment.
I have reverted these back
sumandas0
requested changes
Jan 30, 2025
sumandas0
left a comment
sumandas0
left a comment
There was a problem hiding this comment.
Mostly reviews are for code quality
abhijeet-atlan
requested review from
sumandas0
and removed request for
Madusudanan
Author
|
removed madu from review because of new team structure |
…k vertex. The former will be updated with the total count of propagations to be done once the planning phase is complete and the task begins execution. The latter will be updated as the task progresses, reflecting the count of completed propagations at any given point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DG1924
Design plan ref :Execution Plan - Phase v1 - WIP | 1. Task Vertex
Test cases: DG1924 - TestCase
The task for this ticket:
Add 'assetsCountToPropagate' and 'assetsCountPropagated' params to the task vertex and
update 'assetsCountToPropagate' with a count of the assets count to propagate once the planning phase is finished.
update 'assetsCountPropagated' with a count as the task progresses.
Type of change
Related issues
Checklists
Development
Security
Code review