Skip to content

MESH-445 | Convert domain to subdomain #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankitpatnaik-atlan merged 3 commits into from
Jul 23, 2025
Merged

MESH-445 | Convert domain to subdomain #4447

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
805baa0
feat: enabling convert domain to subdomain
ankitpatnaik-atlan Mar 12, 2025
403dd43
restricting moving parent domain to child domain
ankitpatnaik-atlan Mar 17, 2025
912df6c
change in functions position based on access modifier
ankitpatnaik-atlan Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .../apache/atlas/repository/store/graph/v2/preprocessor/datamesh/DataDomainPreProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,6 @@ private void processUpdateDomain(AtlasEntity entity, AtlasVertex vertex) throws
}

if (!newParentDomainQualifiedName.equals(currentParentDomainQualifiedName) && entity.hasRelationshipAttribute(PARENT_DOMAIN_REL_TYPE)) {
if(storedDomain.getRelationshipAttribute(PARENT_DOMAIN_REL_TYPE) == null &&
StringUtils.isEmpty( (String) storedDomain.getAttribute(PARENT_DOMAIN_QN_ATTR))){
throw new AtlasBaseException(AtlasErrorCode.BAD_REQUEST, "Cannot move Super Domain inside another domain");
}

//Auth check
isAuthorizedToMove(DATA_DOMAIN_ENTITY_TYPE, currentParentDomainHeader, newParentDomainHeader);

Expand Down Expand Up @@ -202,6 +197,8 @@ private void processMoveSubDomainToAnotherDomain(AtlasEntity domain,

domainExists(domainName, targetDomainQualifiedName, domain.getGuid());

isParentDomainMovedToChild(targetDomainQualifiedName, currentDomainQualifiedName);

if(targetDomainQualifiedName.isEmpty()){
//Moving subDomain to make it Super Domain
targetDomainQualifiedName = "default";
Expand Down Expand Up @@ -424,6 +421,12 @@ public void processDelete(AtlasVertex vertex) throws AtlasBaseException {
throw new AtlasBaseException(AtlasErrorCode.OPERATION_NOT_SUPPORTED, "Domain cannot be deleted because some assets are linked to this domain");
}
}

private void isParentDomainMovedToChild(String targetDomainQualifiedName, String currentDomainQualifiedName) throws AtlasBaseException {
if(targetDomainQualifiedName.startsWith(currentDomainQualifiedName)){
throw new AtlasBaseException(AtlasErrorCode.OPERATION_NOT_SUPPORTED, "Cannot move a domain to its child domain");
}
}
}


Loading