Skip to content

POLICY-295 - Added a v2 for unlink policy #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2025
Merged

POLICY-295 - Added a v2 for unlink policy #4669

merged 5 commits into from
May 6, 2025

Conversation

arpit-at
Copy link

@arpit-at arpit-at commented May 5, 2025

Change description

Description here
v2 fixes some issues that are not compatible with v1

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Helm Config Changes for Running Tests (Staging PR)

Does this PR require Helm config changes for testing?

  • Tests are NOT required for this commit. (You can proceed with the PR.) ✅
  • No, Helm config changes are not needed. (You can proceed with the PR.) ✅
  • Yes, I have already updated the config-values on enpla9up36. (You can proceed with the PR.) ✅
  • Yes, but I have NOT updated the config-values. (Please update them before proceeding; or, tests will run with default values.)⚠️

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Copy link

github-actions bot commented May 5, 2025

Integration Test Results

✅ No failures in: SQLAssetTest
✅ No failures in: ADLSAssetTest
✅ No failures in: AnaplanAssetTest
✅ No failures in: QueryParserTest
✅ No failures in: FileTest
✅ No failures in: CubeTest
✅ No failures in: ResourceTest
✅ No failures in: DataverseAssetTest
✅ No failures in: LineageTest
✅ No failures in: TableSearchTest
✅ No failures in: GCSAssetTest
✅ No failures in: S3AssetTest
✅ No failures in: APIAssetTest
✅ No failures in: ConnectionTest
✅ No failures in: AzureEventHubTest
✅ No failures in: LinkTest
✅ No failures in: PresetAssetTest
✅ No failures in: SuggestionsTest
✅ No failures in: WorkflowTest
✅ No failures in: SupersetAssetTest
✅ No failures in: AppAssetTest
❌ Failures found in: CustomMetadataTest (2 failures)
✅ No failures in: DataStudioAssetTest
❌ Failures found in: AtlanTagTest (1 failures)
✅ No failures in: AirflowAssetTest
✅ No failures in: CustomAssetTest
✅ No failures in: GlossaryTest
✅ No failures in: KafkaTest

Some tests failed or results were missing. Total failures: 3

@arpit-at arpit-at changed the title Added a v2 for unlink policy POLICY-295: Added a v2 for unlink policy May 6, 2025
@arpit-at arpit-at changed the title POLICY-295: Added a v2 for unlink policy POLICY-295 - Added a v2 for unlink policy May 6, 2025
@arpit-at arpit-at merged commit 300227e into staging May 6, 2025
45 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants