feat: add title attribute to Compiled style tag#1649
feat: add title attribute to Compiled style tag#1649pancaspe87 wants to merge 1 commit intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: b2531bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| insertAt({ | ||
| selector: 'head', | ||
| append: '<style>' + stylesheet + '</style>', | ||
| append: '<style title="compiled">' + stylesheet + '</style>', |
There was a problem hiding this comment.
Btw, do we inline CSS also in webpack? I don't think I have seen inlineCss for it
|
ooh good idea 👍 do you reckon it would be useful to also add this to the SSR styles that have the (perhaps we can use |
|
We already have some similar behaviour for the runtime, maybe we should match that? |
hmm yeah maybe we could keep (i'm reluctant to use |
TBH, I am not sure if this is a valuable change considering these devlop issues . Also, we know that classes starting with
_are usually Compiled; hence, we can just look for it.However, it may save some keystrokes when debugging :)
Dev mode

It seems that we are having multiple style tags when extraction is not enabled, only one is getting the
titleattributeVS
Prod mode

We can easily discern what style is for Compiled.