[Ignore] Add tests for remaining transforms with defer #590
Conversation
# Conflicts: # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/transforms/DeferredDeepRenameTestSnapshot.kt # test/src/test/kotlin/graphql/nadel/tests/next/fixtures/defer/transforms/RenamedTypeIsDeferredTestSnapshot.kt
felipe-gdr
left a comment
felipe-gdr
left a comment
There was a problem hiding this comment.
The tests don't look right to me, can you please have a look at my comments?
...phql/nadel/tests/next/fixtures/defer/transforms/DeferWithTransformThrowsErrorTestSnapshot.kt
Show resolved
Hide resolved
...n/graphql/nadel/tests/next/fixtures/defer/transforms/DeferredRenamedInputTypeTestSnapshot.kt
Show resolved
Hide resolved
| result = """ | ||
| | { | ||
| | "data": { | ||
| | "aErrors": {} |
There was a problem hiding this comment.
There's not incremental data in the assertion here as well.
There was a problem hiding this comment.
In this test, there is not supposed to be incremental data, because there is no data in the aErrors field.
This test is to ensure that the BError type does not get returned in the aErrors field
felipe-gdr
left a comment
felipe-gdr
left a comment
There was a problem hiding this comment.
I'm still missing the deferred behaviour in some tests.
If that's part of the scenario you're testing, could add a description to the test class explaining why nothing is being deferred?
| | query (${'$'}v0: PathType!) { | ||
| | me { | ||
| | profilePicture { | ||
| | path(type: ${'$'}v0) |
There was a problem hiding this comment.
Why is @path not being deferred?
| service = "A", | ||
| query = """ | ||
| | { | ||
| | aErrors { |
There was a problem hiding this comment.
I'm confused by this one... What deferred behaviour are we testing?
sbarker2
changed the title
adding defer test for the remaining transforms: