Conversation
|
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
| @State(Scope.Benchmark) | ||
| @Warmup(iterations = 5, time = 5) | ||
| @Measurement(iterations = 5) | ||
| @Fork(2) |
There was a problem hiding this comment.
Not a blocker for this PR: For GraphQL Java benchmarks we had slightly fewer warmup and measurement runs.
Usually 2 for warmup and 2-3 for measurement
Because the GraphQL Java benchmark tests run on every commit we had to be more careful there about the total running time for the tests (we arbitrarily set a limit of about 1 hour).
| @Benchmark | ||
| @BenchmarkMode(Mode.AverageTime) | ||
| @OutputTimeUnit(TimeUnit.MILLISECONDS) | ||
| fun bechmarkThroughput() { |
There was a problem hiding this comment.
Nit: this is a typo, should be benchmark
| """ | ||
|
|
||
| println(logMessage) | ||
| // println(logMessage) |
There was a problem hiding this comment.
Nit: Did you mean to leave this comment out?
| @@ -4,6 +4,7 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinCompile | |||
| plugins { | |||
There was a problem hiding this comment.
Nit: you can remove WIP from the PR name, to indicate you're ready for a review
4 participants
No description provided.