-
Notifications
You must be signed in to change notification settings - Fork 25
Refactor contexts #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gnawf
wants to merge
14
commits into
master
Choose a base branch
from
refactor-contexts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor contexts #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4505c3 to
53e749f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #693 to create a more cohesive context system for execution.
Previously we
NadelExecutionContextone for every call toNadel.executeNadelServiceExecutionContextone for every call toNextgenEngine.executeTopLevelFieldNadelTransformServiceExecutionContextone for every transform per operation execution.NadelTransform.Stateone for every field that the transform runs on.So now we have
NadelExecutionContextone for every call toNadel.executeNadelOperationExecutionContextone for every call toNextgenEngine.executeTopLevelFieldNadelTransformOperationContextone for every transform per operation execution.NadelTransformFieldContextone for every field that the transform runs on.So these classes were renamed
NadelServiceExecutionContext→NadelOperationExecutionContextNadelTransformServiceExecutionContext→NadelTransformOperationContextNadelTransform.State→NadelTransformFieldContextSome other renames
NadelTransform.isApplicable->NadelTransform.getTransformFieldContextNadelTransform.buildContext->NadelTransform.getTransformOperationContextEach of the contexts has a reference to the parent context, so we have a good way to reference objects from upper portions of execution e.g. can do
transformFieldContext.executionContext.engineSchemaetc.This has a good benefit in that our
NadelTransformclass is much simplervs