Skip to content

Commit

Permalink
merge with main
Browse files Browse the repository at this point in the history
  • Loading branch information
marcomura committed Feb 21, 2025
2 parents 80f1a9f + e296026 commit 51c8fb5
Show file tree
Hide file tree
Showing 155 changed files with 2,213 additions and 1,532 deletions.
10 changes: 9 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,20 @@ module.exports = {
],
},
],
"no-unused-vars": ["error", {
"vars": "all",
"args": "none",
"caughtErrors": "all",
"ignoreRestSiblings": false,
}],
'brace-style': 'off',
'no-throw-literal': 'error',
'no-var': 'error',
'prefer-const': 'error',
curly: 'error',
eqeqeq: ['error', 'always'],
semi: 'off',
'@stylistic/js/semi': ['error', 'always'],
'no-throw-literal': 'error',
},
settings: {
react: {
Expand Down
41 changes: 41 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,44 @@
## What's new in 3.4.8

### Features

- Added a new toggle switch in 'Start work' page to choose if the new branch should be automatically pushed to remote.

## What's new in 3.4.7

### Features

- Finalized code for Auth UI experiment.

### Bug Fixes

- Fixed 'Create Jira issue' page getting stuck on the loader when the first Jira server is unreachable.
- Fixed 'Start work' not working when another 'Start work' tab is open.

## What's new in 3.4.6

### Features

- Cleaned up feature flag for Jira Cloud authentication from Remote Development Environments
- Placed code for Auth UI experiment. Still needs additional work before we turn this on.

### Engineeering Excellence

- Cleaned up some of our code with new lint rules
- Added some unit tests around authentication

## What's new in 3.4.5

### Bug Fixes

- Fixed bitbucket PR erroring out due to deprecated API being used

## What's new in 3.4.4

### Bug Fixes

- Fixed images not showing up in Jira tickets' description and comments

## What's new in 3.4.3

### Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion e2e/tests/auth.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('Auth User', async () => {
after(async () => {});

it('in SideBarView should see Create issue... button', async () => {
let atlasDrawer = sideBarView.findElement(By.id('workbench.view.extension.atlascode-drawer'));
const atlasDrawer = sideBarView.findElement(By.id('workbench.view.extension.atlascode-drawer'));
expect(atlasDrawer).to.not.be.undefined;

const createIssueButton = atlasDrawer.findElement(By.css('[aria-label="Create issue..."]'));
Expand Down
2 changes: 1 addition & 1 deletion e2e/tests/no-auth.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('Atlassian Extension SideBar', async () => {
after(async () => {});

it('should have a login action suggestion', async () => {
let atlasDrawer = sideBarView.findElement(By.id('workbench.view.extension.atlascode-drawer'));
const atlasDrawer = sideBarView.findElement(By.id('workbench.view.extension.atlascode-drawer'));
expect(atlasDrawer).to.not.be.undefined;

// find element by aria-label: "Please login to Jira"
Expand Down
13 changes: 13 additions & 0 deletions images/arrow-left.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions images/arrow-right.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/vscode-logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 51c8fb5

Please sign in to comment.