Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axon 72 new onboarding auth UI #116

Merged
merged 14 commits into from
Feb 14, 2025
Merged

Axon 72 new onboarding auth UI #116

merged 14 commits into from
Feb 14, 2025

Conversation

cabella-dot
Copy link
Contributor

@cabella-dot cabella-dot commented Feb 13, 2025 •
edited
Loading

(WIP PR)

Loom demo: https://www.loom.com/share/e8d63df3d0754334b52e7bf9d5981b87

What:

  • updated the auth flow UI to be in line with new designs.
  • separated auth component to new JiraBitbucketOnboarding component to help with readability
  • Added @vscode/webview-ui-toolkit dep for native vscode styles

Next:

  • add analytics
  • fix stepping before configuration is completed bug

@cabella-dot cabella-dot self-assigned this Feb 13, 2025
@cabella-dot cabella-dot marked this pull request as draft February 13, 2025 20:53
@bwieger-atlassian-com
Copy link
Collaborator

https://www.loom.com/share/c80fa240720443a0858e66907ee07967?sid=22123340-acd3-41fb-9fcd-3c5dacfce1aa

@cabella-dot
Copy link
Contributor Author

Updated Loom demo with some bug fixes: https://www.loom.com/share/cee89aae58844f4ab33b28270960a93a?sid=692edb48-5731-4e5b-b461-94d50fce2400

cc @bwieger-atlassian-com

@cabella-dot cabella-dot marked this pull request as ready for review February 14, 2025 21:27
marcomura
marcomura approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@marcomura marcomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, great change!! thank you!

@cabella-dot cabella-dot merged commit 8b7878e into main Feb 14, 2025
2 checks passed
@cabella-dot cabella-dot deleted the AXON-72-new-onboarding-auth-ui branch February 14, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwieger-atlassian-com bwieger-atlassian-com bwieger-atlassian-com left review comments

@marcomura marcomura marcomura approved these changes

@sdzh-atlassian sdzh-atlassian Awaiting requested review from sdzh-atlassian sdzh-atlassian is a code owner

Assignees

@cabella-dot cabella-dot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cabella-dot @bwieger-atlassian-com @marcomura