Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AXON-110] BitBucket DC PAT Auth Bug #125

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

bwieger-atlassian-com
Copy link
Collaborator

@bwieger-atlassian-com bwieger-atlassian-com commented Feb 15, 2025

Users were reporting issues authenticating with PAT on BitBucket DC.

This fixes it.

I looked into adding unit tests for this file. There are many things to mock out here to make this efficient.

I'm punting on unit tests here.
Instead, I will look at UI testing.

Before After
Screenshot 2025-02-14 at 4 04 22 PM image

@bwieger-atlassian-com bwieger-atlassian-com changed the title BitBucket DC PAT Auth Bug [AXON-110] BitBucket DC PAT Auth Bug Feb 15, 2025
Copy link
Member

@sdzh-atlassian sdzh-atlassian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah that file would definitely be really hard to write tests for, lol :)
Ship it! ⛵

@bwieger-atlassian-com bwieger-atlassian-com merged commit a90428d into main Feb 18, 2025
2 checks passed
@bwieger-atlassian-com bwieger-atlassian-com deleted the AXON-110-BitBucket-DC-PAT-Auth-Bug branch February 18, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants