[AXON-145] Added branch name validation for space characters #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomura
requested review from
bwieger-atlassian-com,
sdzh-atlassian and
cabella-dot
as code owners
bwieger-atlassian-com
approved these changes
Feb 20, 2025
marcomura
deleted the
AXON-145-start-work-failed-because-of-a-space-at-the-end-of
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://bitbucket.org/atlassianlabs/atlascode/issues/771/error-start-work-failed-because-of-a-space
If the branch name contains a space, or ends with a space, the branch can't be created.
The cleanest way to solve this is adding a field validation on the UI itself, so it doesn't allow the space character to be typed. To be consistent with other logic, the space character is being replaced with a dash
-while typing.Typing "This is a branch" will result in typing "This-is-a-branch".