Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AXON-109] Expose toggle switch to push branch to remote (Start work) #137

Merged

Conversation

marcomura
Copy link
Contributor

@marcomura marcomura commented Feb 20, 2025

With this PR, the Start Work view exposes a toggle switch to control if the new branch should be automatically pushed to remote or not.
The toggle switch is defaulted to true, to keep parity with today's behavior.

The status of the new toggle is being instrumented within the workStarted event.

This addresses the following open issues:
Add settings to not push instantly to remote #90
Create branch as a local branch during "Start work"

Here how it looks like:
image

@marcomura marcomura changed the title [AXON-109] Expose toggle switch to push branch to origin (Start work) [AXON-109] Expose toggle switch to push branch to remote (Start work) Feb 20, 2025
sdzh-atlassian
sdzh-atlassian previously approved these changes Feb 20, 2025
Copy link
Member

@sdzh-atlassian sdzh-atlassian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!⛵

Still can't believe such a straightforward change is 10 files of boilerplate because of IPC lol

@marcomura
Copy link
Contributor Author

Ship it!⛵

Still can't believe such a straightforward change is 10 files of boilerplate because of IPC lol

It's also pretty weird that we have 3 different copies of createOrCheckoutBranch when at most we should need 2 (one for Jira and one for BitBucket)...

@marcomura marcomura merged commit e296026 into main Feb 21, 2025
2 checks passed
@marcomura marcomura deleted the AXON-109-allow-for-start-work-to-be-configured-to-push branch February 21, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants