[AXON-19] fix: pass FX3 client vars to build #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdzh-atlassian
requested review from
bwieger-atlassian-com and
cabella-dot
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
When doing the round of bug bashing today, we caught that the
atlascodefeature flag client initialization vars are not getting passed to the build environment correctly.Now they are 😉
How was this tested?
This is related to CI - so I've only run a pipeline to make sure things work, and checked that the environment variables propagate to the build env correctly. Once this is merged, I'll check the next
nightlyfor any feature flag initialization issues