WIP: Move from npm to yarn #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastelsky
requested review from
bwieger-atlassian-com,
sdzh-atlassian,
cabella-dot and
marcomura
as code owners
pastelsky
removed request for
marcomura,
cabella-dot,
sdzh-atlassian and
bwieger-atlassian-com
pastelsky
force-pushed
the
sk/move-npm-yarn
branch
3 times, most recently
from
80adeae to
610b7f9
Compare
pastelsky
force-pushed
the
sk/move-npm-yarn
branch
from
610b7f9 to
12fa355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review yet.
Usually this sort of thing wouldn't matter — I thought npm's caught up a bit with yarn.
But turns out its still pretty bad when installing fat packages. I was trying to experiment getting @atlassian/editor into the extension,
and at the moment npm takes a good 10+ minutes to npm install @atlassian/editor-core .
It takes several more minutes to run things like npm dedupe (been running for > 20 mins now).
Moving from
npmtoyarnessentially seems like a blocker for any reasonable devloop to work with editor core.This is still in draft because it likely requires the extension to be sanity tested once and builds to be fixed.