fix: Attempt a third merge of the reverted PR #314
+2,402
−4,667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
So, I was trying to figure out why is it working for dev but not prod: and then I realised - we do not need very intelligent chunking solutions given we package and ship our extension in one go unlike websites.
So, I have removed a chunking section for CSS from the extension and that seems to have fixed it for the production package.
But the same change is not working for the existing main: so, both deduplication and removal of chunking fixed it for me. But deduplicating is its own thorny issue:
How Has This Been Tested?
Ran through all the views and user actions: followed the script that @cabella-dot did. I am facing two issues right now:
I spent some time looking into if select box might have changed its schema but it has not. And then I figured the same issues exist in
main
too. So, I am not sure anymore how to seprate testing for just this PR so that it successfully gets merged this time.Basic checks:
npm run lint
npm run test
Advanced checks:
Recommendations: