Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling malware added #2636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

error handling malware added #2636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 78 additions & 72 deletions src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,90 +13,96 @@ import { proxyLocalUIForDev } from "~/src/spa-proxy";

export const setupFrontendApp = (app: Express): Express => {

// We run behind ngrok.io so we need to trust the proxy always
// TODO: look into the security of this. Maybe should only be done for local dev?
app.set("trust proxy", true);
app.set("case sensitive routing", false);
app.set("view engine", "hbs");
const viewPath = path.resolve(process.cwd(), "views");
app.set("views", viewPath);
registerHandlebarsPartials(path.resolve(viewPath, "partials"));
registerHandlebarsHelpers();
/**
* Proxy server for running SPA locally,
* Only for Dev environments for hot reload
*/
proxyLocalUIForDev(app);
// Add all routes
app.use(RootRouter);
// We run behind ngrok.io so we need to trust the proxy always
// TODO: look into the security of this. Maybe should only be done for local dev?
app.set("trust proxy", true);
app.set("case sensitive routing", false);
app.set("view engine", "hbs");
const viewPath = path.resolve(process.cwd(), "views");
app.set("views", viewPath);
registerHandlebarsPartials(path.resolve(viewPath, "partials"));
registerHandlebarsHelpers();
/**
* Proxy server for running SPA locally,
* Only for Dev environments for hot reload
*/
proxyLocalUIForDev(app);
// Add all routes
app.use(RootRouter);

return app;
// Error handling middleware
app.use((err: Error, req: Request, res: Response, next: NextFunction) => {
console.error(err.stack);
res.status(500).send("Something went wrong!");
});

return app;
};

const secureHeaders = (app: Express) => {
app.use((_: Request, res: Response, next: NextFunction): void => {
res.locals.nonce = crypto.randomBytes(16).toString("hex");
next();
});
app.use((_: Request, res: Response, next: NextFunction): void => {
res.locals.nonce = crypto.randomBytes(16).toString("hex");
next();
});

const appUrl = process.env.APP_URL || "";
// Content Security Policy
app.use(helmet.contentSecurityPolicy({
useDefaults: true,
directives: {
defaultSrc: ["'self'"],
// Allow <script> tags hosted by ourselves and from atlassian when inserted into an iframe
scriptSrc: ["'self'", appUrl, "https://*.atlassian.net", "https://*.jira.com", "https://connect-cdn.atl-paas.net/",
"'unsafe-inline'", "'strict-dynamic'", (_: Request, res: Response): string => `'nonce-${res.locals.nonce as string}'`],
// Allow XMLHttpRequest/fetch requests
connectSrc: ["'self'", appUrl],
// Allow <style> tags hosted by ourselves as well as style="" attributes
styleSrc: ["'self'", "'unsafe-inline'"],
// Allow using github-for-jira pages as iframes only in jira
frameAncestors: ["https://*.atlassian.net", "https://*.jira-dev.com", "https://*.jira.com"],
//Doesn't allow usage of <base> element
baseUri: ["'none'"],
//Send SCP reports to Atlassian security monitoring
reportUri: "https://web-security-reports.services.atlassian.com/csp-report/github-for-jira",
// Allow self-hosted images, data: images, organization images and the error image
imgSrc: ["'self'", "data:", "https://*.githubusercontent.com", "https://octodex.github.com"]
}
}));
// Enable HSTS with the value we use for education.github.com
app.use(helmet.hsts({
maxAge: 15552000
}));
// X-Frame / Clickjacking protection
// Disabling this. Will probably need to dynamically
// set this based on the referrer URL and match if it's *.atlassian.net or *.jira.com
// app.use(helmet.frameguard({ action: 'deny' }))
// MIME-Handling: Force Save in IE
app.use(helmet.ieNoOpen());
// Disable caching
app.use(helmet.noCache());
// Disable mimetype sniffing
app.use(helmet.noSniff());
// Basic XSS Protection
app.use(helmet.xssFilter());
const appUrl = process.env.APP_URL || "";
// Content Security Policy
app.use(helmet.contentSecurityPolicy({
useDefaults: true,
directives: {
defaultSrc: ["'self'"],
// Allow <script> tags hosted by ourselves and from atlassian when inserted into an iframe
scriptSrc: ["'self'", appUrl, "https://*.atlassian.net", "https://*.jira.com", "https://connect-cdn.atl-paas.net/",
"'unsafe-inline'", "'strict-dynamic'", (_: Request, res: Response): string => `'nonce-${res.locals.nonce as string}'`],
// Allow XMLHttpRequest/fetch requests
connectSrc: ["'self'", appUrl],
// Allow <style> tags hosted by ourselves as well as style="" attributes
styleSrc: ["'self'", "'unsafe-inline'"],
// Allow using github-for-jira pages as iframes only in jira
frameAncestors: ["https://*.atlassian.net", "https://*.jira-dev.com", "https://*.jira.com"],
//Doesn't allow usage of <base> element
baseUri: ["'none'"],
//Send SCP reports to Atlassian security monitoring
reportUri: "https://web-security-reports.services.atlassian.com/csp-report/github-for-jira",
// Allow self-hosted images, data: images, organization images and the error image
imgSrc: ["'self'", "data:", "https://*.githubusercontent.com", "https://octodex.github.com"]
}
}));
// Enable HSTS with the value we use for education.github.com
app.use(helmet.hsts({
maxAge: 15552000
}));
// X-Frame / Clickjacking protection
// Disabling this. Will probably need to dynamically
// set this based on the referrer URL and match if it's *.atlassian.net or *.jira.com
// app.use(helmet.frameguard({ action: 'deny' }))
// MIME-Handling: Force Save in IE
app.use(helmet.ieNoOpen());
// Disable caching
app.use(helmet.noCache());
// Disable mimetype sniffing
app.use(helmet.noSniff());
// Basic XSS Protection
app.use(helmet.xssFilter());

// Remove the X-Powered-By
// This particular combination of methods works
app.disable("x-powered-by");
app.use(helmet.hidePoweredBy());
// Remove the X-Powered-By
// This particular combination of methods works
app.disable("x-powered-by");
app.use(helmet.hidePoweredBy());
};

export const getFrontendApp = (): Express => {

const app: Express = express();
const app: Express = express();

app.use(elapsedTimeMetrics);
app.use(elapsedTimeMetrics);

if (process.env.FORCE_HTTPS) {
app.use(HTTPS({ trustProtoHeader: true }));
}
if (process.env.FORCE_HTTPS) {
app.use(HTTPS({ trustProtoHeader: true }));
}

setupFrontendApp(app);
secureHeaders(app);
setupFrontendApp(app);
secureHeaders(app);

return app;
return app;
};