Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golang and golang.org/x/net versions #736

Merged

Conversation

rahulreddy15
Copy link
Contributor

Upgraded golang version to v1.23.6
Upgraded golang.org/x/net to v0.35.0

We need to upgrade these libraries to fix security issues detected by trivy.
PFA the security analysis output from trivy.
altassian-gostatsd.txt

Copy link

Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution.
If your email is listed below, please ensure that you sign the CLA with the same email address.

The following users still need to sign our CLA:
❌rahulreddy15

Already signed the CLA? To re-check, try refreshing the page.

@hstan
Copy link
Member

hstan commented Mar 17, 2025

re: test failure
#734 (comment)

@hstan hstan self-requested a review March 17, 2025 10:25
@hstan
Copy link
Member

hstan commented Mar 17, 2025

@rahulreddy15
I reviewed the failed test and believe the test case should be removed. The logic for adding a host was intentionally removed, as it is not the responsibility of this library. More importantly, it should not add a tag for metrics.

As you mentioned in this issue, a bug in previous Go versions caused parallel test execution to behave incorrectly, which is why this test did not fail earlier.

Please proceed with removing the failed test case.

@hstan hstan mentioned this pull request Mar 17, 2025
@hstan
Copy link
Member

hstan commented Mar 17, 2025

@rahulreddy15 actually I've created #744 please update your PR once it's merged

@hstan
Copy link
Member

hstan commented Mar 18, 2025

@rahulreddy15 the PR has been merged, please merge master into your branch

@rahulreddy15 rahulreddy15 force-pushed the upgrade/golang_and_xnet_version_upgrade branch from 63eb8a5 to e933eb4 Compare March 18, 2025 09:16
@rahulreddy15
Copy link
Contributor Author

@hstan Rebased the branch with master

@hstan hstan merged commit 71c6190 into atlassian:master Mar 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants