Skip to content

fix: don't exit on cmd failure #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 4, 2024
Merged

fix: don't exit on cmd failure #177

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
601e6eb
fix: don't exit on cmd failure
ceelogre Dec 3, 2024
8a55cac
fix: re-add values
ceelogre Dec 3, 2024
c983619
fix: add new variables
ceelogre Dec 3, 2024
2073c43
test: add container name
ceelogre Dec 3, 2024
ee31207
fix: match ports
ceelogre Dec 3, 2024
7938d3a
fix: add devpulse email
ceelogre Dec 3, 2024
658f8c9
fix: port
ceelogre Dec 3, 2024
58b8dcd
fix: port
ceelogre Dec 3, 2024
51a70bb
fix: remove container name
ceelogre Dec 3, 2024
d58a2b0
fix: remove extraneous node env
ceelogre Dec 4, 2024
fa671d7
fix: add jwt key
ceelogre Dec 4, 2024
e4b8139
fix: run on push
ceelogre Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions .github/workflows/docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,13 @@ jobs:
NODE_ENV: "production"
PUSHER_CLUSTER: ${{ secrets.PUSHER_CLUSTER }}
PUSHER_APP_ID: ${{ secrets.PUSHER_APP_ID }}
PUSHER_APP_KEY: ${{ secrets.PUSHER_KEY }}
PUSHER_APP_SECRET: ${{ secrets.PUSHER_APP_SECRET }}
PUSHER_KEY: ${{ secrets.PUSHER_KEY }}
PUSHER_SECRET: ${{ secrets.PUSHER_SECRET }}
DEVPULSE_EMAIL: ${{ secrets.DEVPULSE_EMAIL }}
API_KEY: ${{ secrets.API_KEY }}
SENDER_NAME: ${{ secrets.SENDER_NAME }}
PORT: ${{ secrets.PORT }}
JWT_SECRET: ${{ secrets.JWT_SECRET }}


steps:
Expand All @@ -41,13 +45,22 @@ jobs:
username: ${{ secrets.DO_USERNAME }}
key: ${{ secrets.DO_KEY }}
port: ${{ secrets.DO_PORT }}
envs: MONGO_PROD_DB,REGISTER_FRONTEND_URL,REGISTER_ORG_FRONTEND_URL,NODE_ENV,FRONTEND_LINK,ADMIN_EMAIL,ADMIN_PASS,COORDINATOR_EMAIL,COORDINATOR_PASS,GH_TOKEN, PUSHER_CLUSTER
envs: MONGO_PROD_DB,REGISTER_FRONTEND_URL,REGISTER_ORG_FRONTEND_URL,NODE_ENV,FRONTEND_LINK,ADMIN_EMAIL,ADMIN_PASS,COORDINATOR_EMAIL,COORDINATOR_PASS,GH_TOKEN, PUSHER_CLUSTER, PUSHER_APP_ID, PUSHER_KEY, PUSHER_SECRET, API_KEY, SENDER_NAME, DEVPULSE_EMAIL, PORT, JWT_SECRET
script: |
set -e # Exit immediately if a command exits with a non-zero status
set -x # Print commands and their arguments as they are executed
touch env
echo "MONGO_PROD_DB=${MONGO_PROD_DB}" >> env
echo "MONGO_PROD_DB=${MONGO_PROD_DB}" > env
echo "FRONTEND_LINK=${FRONTEND_LINK}" >> env
echo "NODE_ENV=${NODE_ENV}" >> env
echo "PUSHER_CLUSTER=${PUSHER_CLUSTER}" >> env
echo "PUSHER_APP_ID=${PUSHER_APP_ID}" >> env
echo "PUSHER_KEY=${PUSHER_KEY}" >> env
echo "PUSHER_SECRET=${PUSHER_SECRET}" >> env
echo "DEVPULSE_EMAIL=${DEVPULSE_EMAIL}" >> env
echo "API_KEY=${API_KEY}" >> env
echo "SENDER_NAME=${SENDER_NAME}" >> env
echo "PORT=${PORT}" >> env
echo "JWT_SECRET=${JWT_SECRET}" >> env
# Pull the latest image
docker pull ${{ secrets.DOCKER_HUB_USERNAME2 }}/atlp-devpulse-bn:latest
Expand All @@ -56,7 +69,7 @@ jobs:
docker rm $(docker ps -aq --filter publish=4008) || true
# Run new container
output=$( docker run -d \
-p 4008:3000 \
-p 4008:5000 \
--env-file env \
${{ secrets.DOCKER_HUB_USERNAME2 }}/atlp-devpulse-bn:latest)
echo $output
Expand Down