Fix tel #123

mutsinziisaac · 2024-09-12T21:50:19Z

PR Description
This PR refactors the user model to save the country code alongside the phone number and updates the relevant files accordingly.

Description of tasks that were expected to be completed

Refactor the user model to combine country code and phone number.
Update files affected by this change (especially those involving user communication).

Previously, the country code and phone number were stored separately in MongoDB, which created a poor user experience for managers and admins when communicating or retrieving a trainee's phone number.

How has this been tested?

Clone the repo.
Checkout the branch fix-tel.
Set up the environment variables as indicated in .env.example.
Run npm install followed by npm run dev to ensure the app runs successfully.

Deployed Link:

N/A

Track PR (Issue number & link):
N/A

Screenshots (If appropriate):
N/A

vercel · 2024-09-12T21:50:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
atlp-devpulse-fn	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 26, 2024 6:25am

Mugisha146

Great job

ncutixavier · 2024-09-23T08:45:08Z

@mutsinziisaac You have many unnecessary changes

ncutixavier

Please disable your formatter to avoid unnecessary changes

ncutixavier · 2024-09-23T08:46:13Z

src/components/form/RegisterForm.tsx

+                <Button
+                  type="submit"
+                  label="Signup"
+                  className="my-1  mb-4 sm:w-full w-5/6 "
+                />


Unnecessary formatting

Salim-54 · 2024-09-25T11:32:11Z

I can't merge this

You should make sure that if I select a country I am going to get a suggestion of the relevant country code
and drop down of the country code suggests the country as the country dropdown which is very incorrect.

qlty-cloud-legacy · 2024-09-25T21:22:34Z

Code Climate has analyzed commit c0f7cda and detected 0 issues on this pull request.

View more on Code Climate.

* fix: remove placeholder property * fix code & tell issue * rebasing * fix code issue --------- Co-authored-by: ceelogre <[email protected]>

* Add Not Found Page * Add Sign In Profile Picture Ft-send-bulky-email (#61) * new * added a send email model * email * email Co-authored-by: UmuhireJessie <[email protected]> TO be removed fix: run the app ft-superadmin-roles&permissions(superadmin can view members) feat(ft-user-register): user should be able to create account superAdmin register user fix(routes): Add routes directory add login page and add name field on user registration by superadmin create program bg: Added Loader ft(): programs page role & permission implementation of delete role and permissions ft():delete program implementation of delete role and permissions feature:Application form using Google Form implementation of delete role and permissions ft(): edit program new changes ft():Applicant Dashboard add grading system form feat(admin list applications):view applications ft admin view applications admin update status of candidate application Feature github actions (#119) * fix: remove placeholder property * Have github actions setup with necessary jobs * Have code climate errors removed * Corrected codeclimate issues * --ammend * --ammend --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: Ndahimana Bonheur <[email protected]> * fix: remove placeholder property * #103 Navigation fixed --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: Ndahimana Bonheur <[email protected]> Fix number can't be shared (#130) Co-authored-by: Mugisha <[email protected]> * fix: remove placeholder property * fix duplicate links --------- Co-authored-by: ceelogre <[email protected]> Ft minimize dashboard menu #110 (#140) * fix: remove placeholder property * ft minimize dashboard menu * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * Fix layout spacing between sidebar and main content in AdminLayout * new * Fix layout spacing between sidebar and main content in AdminLayout * fix layout --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> * fix: remove placeholder property * The built-in superadmin account cannot create a program --------- Co-authored-by: ceelogre <[email protected]> Ft shareable job post (#139) * fix: remove placeholder property * Ft():shareable job post page * Feature: Adding shareable job post buttons * Feature: Adding shareable job post buttons * Feature: Adding shareable job post buttons * fix codeclimate issue * add gmail and fix telegram link * add gmail sharing * fix url sharing * fix url * fix url * fix codeclimate * applicant share application --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: dean-daryl <[email protected]> Co-authored-by: Bahati <[email protected]> Co-authored-by: uwituzeb <[email protected]> Ft add favicon (#124) * fix: remove placeholder property * add favicon svg * added favicon * removed unneccessary added port number * resolved conflicts * resolved conflicts * resolved conflicts * add favicon svg * resolved conflicts * removed unneccessary added port number * resolved conflicts * resolved conflicts * added favicon * removed unneccessary added port number * resolved conflicts * resolved conflicts * resolved conflicts * added favicon * removed unneccessary added port number * resolved conflicts * resolved conflicts * resolved conflicts * resolved conflicts * resolved conflicts * resolved conflicts * resolved conflicts --------- Co-authored-by: ceelogre <[email protected]> Fix tel (#123) * fix: remove placeholder property * fix code & tell issue * rebasing * fix code issue --------- Co-authored-by: ceelogre <[email protected]> Fix/update trainee info (#137) * add validations and work on edit * ensure birthdate is correctly set in formData * ensure all formData are populated correctly * fix codeclimate issue * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * update traineUpdate * fix traineUpdate * add loader * add sidebar link for trainee applicants * add redirection after updating * feature: improve trainee details page * handling missing application info, also adding download functionality * fixing error related to download and refactoring * Update TrainneeDetails.tsx * handling issues related to deployment * Fix number can't be shared (#130) Co-authored-by: Mugisha <[email protected]> * #102 sidebar links review (#128) * fix: remove placeholder property * fix duplicate links --------- Co-authored-by: ceelogre <[email protected]> * Ft minimize dashboard menu #110 (#140) * fix: remove placeholder property * ft minimize dashboard menu * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * Fix layout spacing between sidebar and main content in AdminLayout * new * Fix layout spacing between sidebar and main content in AdminLayout * fix layout --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> * #118 fx: builtinSuperAdminCreateProgram (#126) * fix: remove placeholder property * The built-in superadmin account cannot create a program --------- Co-authored-by: ceelogre <[email protected]> * feature: improve trainee details page * handling missing application info, also adding download functionality * Update TrainneeDetails.tsx * adding way to send email and other adjustments * refining and fixing some issues * Update webpack.config.js * customizing way of sending email * refactoring code to fix issue related to code climate * fixing issue for deployment * fixing issues related to refactoring --------- Co-authored-by: MUGISHA Emmanuel <[email protected]> Co-authored-by: Mugisha <[email protected]> Co-authored-by: ISHIMWE Jean Baptiste <[email protected]> Co-authored-by: ceelogre <[email protected]> Co-authored-by: ManziPatrick <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> Co-authored-by: Niyonshuti Jean De Dieu <[email protected]> fixes #168 auth and admin login (#169) * feature: improve trainee details page (#172) * handling missing application info, also adding download functionality * fixing error related to download and refactoring * Update TrainneeDetails.tsx * handling issues related to deployment * Fix number can't be shared (#130) * #102 sidebar links review (#128) * fix: remove placeholder property * fix duplicate links --------- * Ft minimize dashboard menu #110 (#140) * fix: remove placeholder property * ft minimize dashboard menu * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * Fix layout spacing between sidebar and main content in AdminLayout * new * Fix layout spacing between sidebar and main content in AdminLayout * fix layout --------- * #118 fx: builtinSuperAdminCreateProgram (#126) * fix: remove placeholder property * The built-in superadmin account cannot create a program --------- * feature: improve trainee details page * handling missing application info, also adding download functionality * Update TrainneeDetails.tsx * adding way to send email and other adjustments * refining and fixing some issues * Update webpack.config.js * customizing way of sending email * refactoring code to fix issue related to code climate * fixing issue for deployment * fixing issues related to refactoring --------- Co-authored-by: MUREKEZI Ismael <[email protected]> Co-authored-by: MUGISHA Emmanuel <[email protected]> Co-authored-by: Mugisha <[email protected]> Co-authored-by: ISHIMWE Jean Baptiste <[email protected]> Co-authored-by: ceelogre <[email protected]> Co-authored-by: ManziPatrick <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> Ft search job post (#187) * ft(Add search): Add entry search * Will add user seach Job Functionalities --squashed commits * single page to view and search Jobs * will make jobs and search be on same page * updating functionality * Real time searching --------- Co-authored-by: Jmukakalisa <[email protected]> 154 crud application form (#167) * Will add create application feature * Will add update application form feature * Will add view application form feature * Will add dark mode card * Will add create application feature * Will add update application form feature * Will add view application form feature * Will add dark mode card Add Verify Email (#179) Co-authored-by: vegetason <[email protected]> ft(Add search): Add entry search (#136) Co-authored-by: Jmukakalisa <[email protected]> Forget password #147 (#178) * fogetpassword * ft-forget password * reset and forget password * reset and forget password * reset and forget password * reset and forget password * reset password * reset update background * reset update background * reset update background * reset password * reset password * reset password * reset password * yarn.lock * Ft search job post (#187) * ft(Add search): Add entry search * Will add user seach Job Functionalities --squashed commits * single page to view and search Jobs * will make jobs and search be on same page * updating functionality * Real time searching --------- Co-authored-by: Jmukakalisa <[email protected]> * 154 crud application form (#167) * Will add create application feature * Will add update application form feature * Will add view application form feature * Will add dark mode card * Will add create application feature * Will add update application form feature * Will add view application form feature * Will add dark mode card * Add Verify Email (#179) Co-authored-by: vegetason <[email protected]> * resolve comflit * resolve comflit * resolve comflit * resolve comflit --------- Co-authored-by: Aime Brues <[email protected]> Co-authored-by: Jmukakalisa <[email protected]> Co-authored-by: MUGISHA Joseph <[email protected]> Co-authored-by: Irakoze Paulin <[email protected]> Co-authored-by: vegetason <[email protected]> Ft edit, publish and unpublish jobs (#189) * fix: remove placeholder property * fix code & tell issue * will add ft for editing jobs --------- Co-authored-by: ceelogre <[email protected]> Fix fault alerts (#182) * correct error messages * work on resolving fault alerts remove a bug (#190) Co-authored-by: vegetason <[email protected]> Admin dashboard (#181) General search and filtration admin (#184) * general-search-admin * Will add results tab general search updates resolved conflicts admin general search updates fixing code climate issues * resolving conflicts --------- Co-authored-by: MUGISHA Joseph <[email protected]> * add applicant dashboard page * add dashboard cards * integrate with backend * fetch all data from their respective queries * remove console logs * update cohort types and query * fix routes * fix code climate * add graph * fix chart * delete yarn * fix graph and login * fix * trigger * revert --------- Co-authored-by: uwituzeb <[email protected]> Fix job Search (#199) Co-authored-by: vegetason <[email protected]> * feature: improve trainee details page (#172) * handling missing application info, also adding download functionality * fixing error related to download and refactoring * Update TrainneeDetails.tsx * handling issues related to deployment * Fix number can't be shared (#130) * #102 sidebar links review (#128) * fix: remove placeholder property * fix duplicate links --------- * Ft minimize dashboard menu #110 (#140) * fix: remove placeholder property * ft minimize dashboard menu * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * Fix layout spacing between sidebar and main content in AdminLayout * new * Fix layout spacing between sidebar and main content in AdminLayout * fix layout --------- * #118 fx: builtinSuperAdminCreateProgram (#126) * fix: remove placeholder property * The built-in superadmin account cannot create a program --------- * feature: improve trainee details page * handling missing application info, also adding download functionality * Update TrainneeDetails.tsx * adding way to send email and other adjustments * refining and fixing some issues * Update webpack.config.js * customizing way of sending email * refactoring code to fix issue related to code climate * fixing issue for deployment * fixing issues related to refactoring --------- Co-authored-by: MUREKEZI Ismael <[email protected]> Co-authored-by: MUGISHA Emmanuel <[email protected]> Co-authored-by: Mugisha <[email protected]> Co-authored-by: ISHIMWE Jean Baptiste <[email protected]> Co-authored-by: ceelogre <[email protected]> Co-authored-by: ManziPatrick <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> revert changes from develop (#205) fix:dev conflict issues (#207) added preferences page

ceelogre and others added 2 commits August 28, 2024 16:27

fix: remove placeholder property

2f0727f

fix code & tell issue

7d61387

mutsinziisaac assigned ncutixavier, SaddockAime and mugishaj092 Sep 12, 2024

mutsinziisaac added Ready For Review Extra attention is needed DREAM DREAM TEAM labels Sep 13, 2024

mutsinziisaac unassigned ncutixavier, mugishaj092 and SaddockAime Sep 13, 2024

mutsinziisaac requested review from Mugisha146, SaddockAime and mugishaj092 September 13, 2024 09:49

Mugisha146 approved these changes Sep 13, 2024

View reviewed changes

vercel bot deployed to Preview – atlp-devpulse-fn September 16, 2024 11:30 View deployment

robsdagreat self-requested a review September 16, 2024 18:12

robsdagreat approved these changes Sep 16, 2024

View reviewed changes

Philimuhire approved these changes Sep 17, 2024

View reviewed changes

mugishaj092 approved these changes Sep 17, 2024

View reviewed changes

SaddockAime approved these changes Sep 17, 2024

View reviewed changes

ncutixavier reviewed Sep 23, 2024

View reviewed changes

rebasing

46c4f59

mutsinziisaac force-pushed the fix-tel branch from 81cffa0 to 46c4f59 Compare September 24, 2024 11:23

vercel bot deployed to Preview – atlp-devpulse-fn September 24, 2024 11:24 View deployment

rebasing

e799109

vercel bot deployed to Preview – atlp-devpulse-fn September 24, 2024 11:29 View deployment

mutsinziisaac requested a review from ncutixavier September 25, 2024 10:58

mugishaj092 added Ready For Merge and removed Ready For Review Extra attention is needed labels Sep 25, 2024

SaddockAime self-requested a review September 25, 2024 14:39

SaddockAime added Ready For Review Extra attention is needed and removed Ready For Merge labels Sep 25, 2024

fix code issue

c0f7cda

vercel bot deployed to Preview – atlp-devpulse-fn September 25, 2024 21:23 View deployment

mugishaj092 added Ready For Merge and removed Ready For Review Extra attention is needed labels Sep 26, 2024

Salim-54 merged commit 6568857 into develop Sep 26, 2024
7 checks passed

Ishimwe7 pushed a commit that referenced this pull request Oct 10, 2024

Fix tel (#123)

6ce4387

* fix: remove placeholder property * fix code & tell issue * rebasing * fix code issue --------- Co-authored-by: ceelogre <[email protected]>

Ismaelmurekezi pushed a commit that referenced this pull request Oct 13, 2024

Fix tel (#123)

90fc6b1

* fix: remove placeholder property * fix code & tell issue * rebasing * fix code issue --------- Co-authored-by: ceelogre <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix tel #123

Fix tel #123

Uh oh!

mutsinziisaac commented Sep 12, 2024 •

edited

Loading

Uh oh!

vercel bot commented Sep 12, 2024 •

edited

Loading

Uh oh!

Mugisha146 left a comment

Uh oh!

ncutixavier commented Sep 23, 2024

Uh oh!

ncutixavier left a comment

Uh oh!

ncutixavier Sep 23, 2024

Uh oh!

Salim-54 commented Sep 25, 2024

Uh oh!

qlty-cloud-legacy bot commented Sep 25, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Fix tel #123

Fix tel #123

Uh oh!

Conversation

mutsinziisaac commented Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mugisha146 left a comment

Choose a reason for hiding this comment

Uh oh!

ncutixavier commented Sep 23, 2024

Uh oh!

ncutixavier left a comment

Choose a reason for hiding this comment

Uh oh!

ncutixavier Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

Salim-54 commented Sep 25, 2024

Uh oh!

qlty-cloud-legacy bot commented Sep 25, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

mutsinziisaac commented Sep 12, 2024 •

edited

Loading

vercel bot commented Sep 12, 2024 •

edited

Loading