#40 Fix single trainee detail page #125

Ismaelmurekezi · 2024-09-13T08:01:53Z

PR Description

This PR is for correcting issue related to single trainee detail page by adding missing functionality. Also following best practices to avoid some error which was rising during test on github , improving user experience

Desciption of task on what was needed to be done

Refactoring
Refining User Interface
Fixing some issues

How to test this PR

Locally
-First ,you have to switch to fix-single-detail-page branch
-Login as admin then under trainee-applicants page you choose view
Email:[email protected]
Password:password123

-My branch: fix-single-trainee-detail-page

Deploy
-For deployed one ,you click issue link, then under vercel bot
-Click Preview , Login after creating account , then the rest is same as those of local

https://atlp-devpulse-fn-git-fix-sin-0e7ca9-devpulses-projects-62c56cf1.vercel.app/

Track PR

issue link:
#125

Before

After

vercel · 2024-09-13T08:01:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
atlp-devpulse-fn	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 10:08pm

gitguardian · 2024-09-13T08:02:30Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

mugishaj092

Also rember to add other action button (Approve and Reject)

.codeclimate.yml

Ishimwe7

Please consider feedbacks given and resolve conflicts

qlty-cloud-legacy · 2024-09-25T22:08:00Z

Code Climate has analyzed commit d46bc6d and detected 0 issues on this pull request.

View more on Code Climate.

* feature: improve trainee details page * handling missing application info, also adding download functionality * fixing error related to download and refactoring * Update TrainneeDetails.tsx * handling issues related to deployment * Fix number can't be shared (#130) Co-authored-by: Mugisha <[email protected]> * #102 sidebar links review (#128) * fix: remove placeholder property * fix duplicate links --------- Co-authored-by: ceelogre <[email protected]> * Ft minimize dashboard menu #110 (#140) * fix: remove placeholder property * ft minimize dashboard menu * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard by icon and categorize into section * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * fix minimize dashboard scrollbar * Fix layout spacing between sidebar and main content in AdminLayout * new * Fix layout spacing between sidebar and main content in AdminLayout * fix layout --------- Co-authored-by: ceelogre <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> * #118 fx: builtinSuperAdminCreateProgram (#126) * fix: remove placeholder property * The built-in superadmin account cannot create a program --------- Co-authored-by: ceelogre <[email protected]> * feature: improve trainee details page * handling missing application info, also adding download functionality * Update TrainneeDetails.tsx * adding way to send email and other adjustments * refining and fixing some issues * Update webpack.config.js * customizing way of sending email * refactoring code to fix issue related to code climate * fixing issue for deployment * fixing issues related to refactoring --------- Co-authored-by: MUGISHA Emmanuel <[email protected]> Co-authored-by: Mugisha <[email protected]> Co-authored-by: ISHIMWE Jean Baptiste <[email protected]> Co-authored-by: ceelogre <[email protected]> Co-authored-by: ManziPatrick <[email protected]> Co-authored-by: Prince-Kid <[email protected]> Co-authored-by: Mucyo Prince <[email protected]> Co-authored-by: Aime-Patrick <[email protected]> Co-authored-by: Niyonshuti Jean De Dieu <[email protected]>

Ismaelmurekezi requested review from Ishimwe7 and Prince-Kid September 13, 2024 08:49

Ismaelmurekezi added the DREAM DREAM TEAM label Sep 13, 2024

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 13, 2024 09:50 Failure

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 13, 2024 09:53 Failure

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 13, 2024 09:56 Failure

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 13, 2024 10:07 Failure

Prince-Kid approved these changes Sep 13, 2024

View reviewed changes

Ismaelmurekezi added Ready For Review Extra attention is needed labels Sep 13, 2024

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 13, 2024 15:20 Failure

Ismaelmurekezi removed the Ready For Review Extra attention is needed label Sep 13, 2024

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 13, 2024 15:37 Failure

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 14, 2024 14:03 Failure

Ismaelmurekezi requested a review from mugishaj092 September 15, 2024 11:17

Ismaelmurekezi added the Ready For Review Extra attention is needed label Sep 15, 2024

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 15, 2024 21:54 Failure

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 15, 2024 22:20 Failure

mugishaj092 requested changes Sep 16, 2024

View reviewed changes

.codeclimate.yml Show resolved Hide resolved

Ishimwe7 reviewed Sep 16, 2024

View reviewed changes

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 16, 2024 08:53 Failure

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 16, 2024 09:28 Failure

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 16, 2024 09:35 Failure

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 16, 2024 11:20 Failure

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 16, 2024 12:08 Failure

vercel bot deployed to Preview – atlp-devpulse-fn September 16, 2024 12:12 View deployment

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 16, 2024 12:38 Failure

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 16, 2024 13:06 Failure

Merge branch 'develop' into fix-single-trainee-detail-page

9939f21

vercel bot deployed to Preview – atlp-devpulse-fn September 24, 2024 15:51 View deployment

tysepa self-requested a review September 24, 2024 17:42

tysepa approved these changes Sep 24, 2024

View reviewed changes

Merge branch 'develop' into fix-single-trainee-detail-page

717b905

vercel bot deployed to Preview – atlp-devpulse-fn September 25, 2024 12:49 View deployment

Update webpack.config.js

0e60ac1

vercel bot deployed to Preview – atlp-devpulse-fn September 25, 2024 12:56 View deployment

customizing way of sending email

5127ba0

vercel bot deployed to Preview – atlp-devpulse-fn September 25, 2024 19:58 View deployment

refactoring code to fix issue related to code climate

c3b4759

vercel bot had a problem deploying to Preview – atlp-devpulse-fn September 25, 2024 20:54 Failure

fixing issue for deployment

feaaf30

vercel bot deployed to Preview – atlp-devpulse-fn September 25, 2024 21:33 View deployment

fixing issues related to refactoring

d46bc6d

vercel bot deployed to Preview – atlp-devpulse-fn September 25, 2024 22:08 View deployment

mugishaj092 added Ready For Merge and removed Ready For Review Extra attention is needed labels Sep 26, 2024

mugishaj092 requested a review from Ishimwe7 September 26, 2024 06:39

Salim-54 merged commit e30941c into develop Sep 26, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

#40 Fix single trainee detail page #125

#40 Fix single trainee detail page #125

Uh oh!

Ismaelmurekezi commented Sep 13, 2024 •

edited by mugishaj092

Loading

Uh oh!

vercel bot commented Sep 13, 2024 •

edited

Loading

Uh oh!

gitguardian bot commented Sep 13, 2024 •

edited

Loading

Uh oh!

mugishaj092 left a comment

Uh oh!

Uh oh!

Ishimwe7 left a comment •

edited

Loading

Uh oh!

qlty-cloud-legacy bot commented Sep 25, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

#40 Fix single trainee detail page #125

#40 Fix single trainee detail page #125

Uh oh!

Conversation

Ismaelmurekezi commented Sep 13, 2024 • edited by mugishaj092 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

Desciption of task on what was needed to be done

How to test this PR

Track PR

Uh oh!

vercel bot commented Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitguardian bot commented Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

️✅ There are no secrets present in this pull request anymore.

Uh oh!

mugishaj092 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Ishimwe7 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot commented Sep 25, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Ismaelmurekezi commented Sep 13, 2024 •

edited by mugishaj092

Loading

vercel bot commented Sep 13, 2024 •

edited

Loading

gitguardian bot commented Sep 13, 2024 •

edited

Loading

Ishimwe7 left a comment •

edited

Loading