#284 show skeleton on cohort page #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ismaelmurekezi
changed the title
Ismaelmurekezi
force-pushed
the
ft-cohort-skeleton
branch
from
f956a97 to
4a6a872
Compare
Ismaelmurekezi
requested review from
Mugisha146,
Philimuhire,
Prince-Kid and
SaddockAime
Ismaelmurekezi
added
Ready For Merge
Ready For Review
Prince-Kid
approved these changes
Dec 2, 2024
Ismaelmurekezi
changed the title
Closed
SaddockAime
changed the title
Ismaelmurekezi
force-pushed
the
ft-cohort-skeleton
branch
from
4a6a872 to
f505149
Compare
Mugisha146
approved these changes
Dec 3, 2024
SaddockAime
approved these changes
Dec 3, 2024
Ismaelmurekezi
force-pushed
the
ft-cohort-skeleton
branch
from
f505149 to
8b63347
Compare
|
Code Climate has analyzed commit 8b63347 and detected 0 issues on this pull request. View more on Code Climate. |
ncutixavier
approved these changes
Dec 4, 2024
bahati10
pushed a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This is about adding skeleton to single cohort and cohort page while data is being loaded. It include some label which was missing on add and update cohort models
What was expected from this PR
How to test this PR
Credential:
Username:[email protected]
Password:password123
Deployed link: https://atlp-devpulse-fn-git-ft-coho-0267ca-devpulses-projects-62c56cf1.vercel.app/#/home
Issue link: #284
Screenshot
