Skip to content

Optimize time of loading assets #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Optimize time of loading assets #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2417da9
Lazy loading images
SHYAKA-Aime Dec 5, 2024
412cea3
fix build issue
SHYAKA-Aime Dec 6, 2024
9812214
lazy loading icons
SHYAKA-Aime Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/form/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ interface ButtonProps {
className?: string;
role?: string;
label?: string;
children?: ReactNode;
children?: any;
}

const Button: React.FC<ButtonProps> = ({
Expand Down
2 changes: 1 addition & 1 deletion src/components/home/AboutUs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const AboutUs = () => {


<div className="flex flex-col lg:flex-row items-center mb-10 px-10 gap-7 space-x-7">
<img src={image} alt="Andela Engineers" className="w-[500px] h-auto rounded-lg shadow-md mb-6 lg:mb-0" />
<img src={image} alt="Andela Engineers" className="w-[500px] h-auto rounded-lg shadow-md mb-6 lg:mb-0" loading="lazy"/>

<div className='max-w-2xl px-10'>
<h1 className='text-3xl sm:text-4xl md:text-5xl font-bold mb-4 leading-tight dark:text-white'>
Expand Down
2 changes: 1 addition & 1 deletion src/components/home/Blogs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { toast } from 'react-toastify';
const BlogCard = ({ blog }: { blog: Blog }) => (
<div key={blog.id} className="bg-gray-200 dark:bg-dark-frame-bg dark:text-white text-primary shadow-lg rounded-lg cursor-pointer hover:shadow-xl transition duration-300" >
<Link to={`/blogs/${blog.id}`}>
<img src={blog.coverImage} alt={blog.title} className="w-full h-40 object-cover mb-4" />
<img src={blog.coverImage} alt={blog.title} className="w-full h-40 object-cover mb-4" loading="lazy"/>
</Link>
<div className="p-3">
<Link to={`/blogs/${blog.id}`}>
Expand Down
2 changes: 1 addition & 1 deletion src/components/home/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const Footer = () => {
<div className=" dark:bg-dark-bg bg-white text-primary dark:text-white flex flex-wrap justify-around items-center border-t pt-6">
<div className="flex flex-col mb-4 md:mb-0 md:w-auto ">
<Link to="/" className="flex items-center space-x-2">
<img src={logo} alt="Logo" className="h-8 w-auto" />
<img src={logo} alt="Logo" className="h-8 w-auto" loading='lazy'/>
<h1 className="text-lg font-bold font-lexend text-primary dark:text-green">
PULSE
</h1>
Expand Down
1 change: 1 addition & 0 deletions src/components/home/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const Header = () => {
className="cursor-pointer mx-2 fill-[blue]"
src={logo}
style={{ fill: '#333' }}
loading="lazy"
/>
) : (
<img
Expand Down
Loading