Skip to content

Conversation

@shema-surge
Copy link
Contributor

@shema-surge shema-surge commented Sep 12, 2024

PR Description

This PR implements the event invitations and and event cancelling calendar functionalities

Description of tasks that were expected to be completed

  1. Inviting trainees in the created event
  2. Cancelling events
  3. Accepting and declining Invitations
  4. Updating event and guests

Functionality

How has this been tested?

This feature was tested in ApolloStudio

PR Checklist:

  • Task 1. Inviting trainees in the created event
  • Task 2. Cancelling events
  • Task 3. Accepting and declining Invitations
  • Task 4. Updating event and guests

Track PR

Trello Link (#DP-?)

Screenshots (If appropriate)

(Images)

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 12.90323% with 162 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@3c32210). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/eventResolver.ts 6.32% 148 Missing ⚠️
src/helpers/sendEventEmails.ts 35.71% 9 Missing ⚠️
src/utils/templates/eventInvitationTemplates.ts 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #290   +/-   ##
==========================================
  Coverage           ?   17.69%           
==========================================
  Files              ?       85           
  Lines              ?     2882           
  Branches           ?      819           
==========================================
  Hits               ?      510           
  Misses             ?     2363           
  Partials           ?        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacquelineTuyisenge JacquelineTuyisenge added the WIP Work in progress label Sep 17, 2024
@shema-surge shema-surge added Ready for merge The pull request has received all necessary reviews and can be merged and removed WIP Work in progress labels Sep 18, 2024
@shema-surge shema-surge force-pushed the ft-calendar-functionality branch from 3ac3624 to 89fa0aa Compare September 18, 2024 13:48
@shema-surge shema-surge linked an issue Sep 18, 2024 that may be closed by this pull request
Copy link

@RWEMAREMY RWEMAREMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@shema-surge shema-surge added bug Something isn't working and removed Ready for merge The pull request has received all necessary reviews and can be merged labels Sep 21, 2024
Copy link
Contributor

@JacquelineTuyisenge JacquelineTuyisenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I suggest in getting events and accepted events, you can also include their status
  2. after cancelling an event, you can turn the message for ex: '... cancelled successfully'

Others Looks good

@shema-surge shema-surge force-pushed the ft-calendar-functionality branch from 9b7c9c2 to 587407d Compare September 27, 2024 10:42
@ceelogre ceelogre temporarily deployed to ft-calendar-functionality - devpulse-backend PR #290 September 27, 2024 10:42 — with Render Destroyed
@Salim-54 Salim-54 merged commit f892057 into develop Sep 27, 2024
2 checks passed
@ceelogre ceelogre deleted the ft-calendar-functionality branch November 5, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Nova Ready for merge The pull request has received all necessary reviews and can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve calendar functionality

9 participants