Skip to content

Conversation

@janet-barbie
Copy link
Contributor

@janet-barbie janet-barbie commented Nov 4, 2024

PR Description

This pull request implements 2 factor authentication

Description of tasks that were expected to be completed

A user should be able to enable and disable two factor authentication.

Functionality

Login and enable two factor authentication you will be sent a notification email. try to Login an email with an otp code will be sent and two way verification token in your response .then loginWithTwoFactorAuthentication provide a two way verification token and an otp code

How has this been tested?

Tested using graphql appolo server

PR Checklist:

  • Enable Two Factor Authentication.
  • Disable Two Factor Authentication.
  • Login With Two Factor Authentication.

Track PR

Trello Link (#DP-?)
Screenshot 2024-11-04 at 16 04 50
Screenshot 2024-11-04 at 16 06 51
Screenshot 2024-11-04 at 17 02 22
Screenshot 2024-11-04 at 16 07 29

(Images)

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 17.44186% with 71 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@5aea393). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/2fa.resolvers.ts 17.39% 37 Missing and 1 partial ⚠️
src/resolvers/userResolver.ts 13.63% 19 Missing ⚠️
src/utils/2WayAuthentication.ts 17.64% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #407   +/-   ##
==========================================
  Coverage           ?   16.58%           
==========================================
  Files              ?       93           
  Lines              ?     3655           
  Branches           ?     1030           
==========================================
  Hits               ?      606           
  Misses             ?     3038           
  Partials           ?       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RWEMAREMY RWEMAREMY self-requested a review November 6, 2024 11:20
Copy link

@RWEMAREMY RWEMAREMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

Copy link

@RWEMAREMY RWEMAREMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@Salim-54
Copy link

Resolve conflicts

@janet-barbie janet-barbie force-pushed the ft-TwoFactorAuthentication-#303 branch from d700b4b to aa05203 Compare November 15, 2024 08:57
@ceelogre ceelogre temporarily deployed to ft-TwoFactorAuthentication-#303 - devpulse-backend PR #407 November 15, 2024 08:57 — with Render Destroyed
Copy link

@RWEMAREMY RWEMAREMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@Salim-54 Salim-54 merged commit 14bfcde into develop Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Needs Reviews A pull request need reviews to be merged Nova

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants