-
Notifications
You must be signed in to change notification settings - Fork 4
#408: Coordinator can remove trainee #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdb7bf4 to
419b819
Compare
419b819 to
8c231cf
Compare
8c231cf to
0fb1487
Compare
0fb1487 to
becb823
Compare
becb823 to
b920582
Compare
b920582 to
17f2366
Compare
17f2366 to
c785e5a
Compare
c785e5a to
ccc52db
Compare
ccc52db to
fe3eb11
Compare
fe3eb11 to
597a1a1
Compare
597a1a1 to
e6361ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #414 +/- ##
==========================================
Coverage ? 16.57%
==========================================
Files ? 89
Lines ? 3559
Branches ? 1020
==========================================
Hits ? 590
Misses ? 2960
Partials ? 9 ☔ View full report in Codecov by Sentry. |
GSinseswa721
approved these changes
Nov 12, 2024
niyobertin
approved these changes
Nov 12, 2024
Contributor
niyobertin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oliviier-dev
approved these changes
Nov 12, 2024
ncutixavier
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Coordinator is able to remove trainee without any problem before when coordinator removed trainee there was an error now it is working as expected
How has this been tested?
git checkout fx-coordinator-remove-trainneand run the servernpm run devto check if it worksLogin Credentials
email: [email protected]
password: Test@12345
PR Checklist:
Track PR
Trello Link (#408 )
Screenshots (If appropriate)