Skip to content

Conversation

@mpanoathos
Copy link
Contributor

@mpanoathos mpanoathos commented Nov 5, 2024

PR Description

Coordinator is able to remove trainee without any problem before when coordinator removed trainee there was an error now it is working as expected

How has this been tested?

  1. Clone the repository
  2. Navigate on branch git checkout fx-coordinator-remove-trainne and run the server npm run dev to check if it works
  3. Use this link to check if it is working as expected
    Login Credentials
    email: [email protected]
    password: Test@12345

PR Checklist:

  • Task 1.
  • Task 2.
  • Task 3.
  • Task n.

Track PR

Trello Link (#408 )

Screenshots (If appropriate)

image

@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from bdb7bf4 to 419b819 Compare November 5, 2024 20:33
@ceelogre ceelogre temporarily deployed to fx-coordinator-remove-trainne - devpulse-backend PR #414 November 5, 2024 20:33 — with Render Destroyed
@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from 419b819 to 8c231cf Compare November 5, 2024 20:34
@ceelogre ceelogre temporarily deployed to fx-coordinator-remove-trainne - devpulse-backend PR #414 November 5, 2024 20:34 — with Render Destroyed
@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from 8c231cf to 0fb1487 Compare November 5, 2024 20:35
@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from 0fb1487 to becb823 Compare November 5, 2024 20:36
@ceelogre ceelogre temporarily deployed to fx-coordinator-remove-trainne - devpulse-backend PR #414 November 5, 2024 20:36 — with Render Destroyed
@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from becb823 to b920582 Compare November 5, 2024 20:36
@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from b920582 to 17f2366 Compare November 5, 2024 20:39
@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from 17f2366 to c785e5a Compare November 5, 2024 20:41
@ceelogre ceelogre temporarily deployed to fx-coordinator-remove-trainne - devpulse-backend PR #414 November 5, 2024 20:41 — with Render Destroyed
@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from c785e5a to ccc52db Compare November 5, 2024 20:42
@mpanoathos mpanoathos added fighters Team WIP Work in progress labels Nov 5, 2024
@mpanoathos mpanoathos changed the title #408 Coordinator can remove trainee #408: Coordinator can remove trainee Nov 6, 2024
@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from ccc52db to fe3eb11 Compare November 7, 2024 13:45
@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from fe3eb11 to 597a1a1 Compare November 7, 2024 19:53
@mpanoathos mpanoathos force-pushed the fx-coordinator-remove-trainne branch from 597a1a1 to e6361ed Compare November 12, 2024 09:14
@ceelogre ceelogre temporarily deployed to fx-coordinator-remove-trainne - devpulse-backend PR #414 November 12, 2024 09:14 — with Render Destroyed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (develop@ba775e7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/coordinatorResolvers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #414   +/-   ##
==========================================
  Coverage           ?   16.57%           
==========================================
  Files              ?       89           
  Lines              ?     3559           
  Branches           ?     1020           
==========================================
  Hits               ?      590           
  Misses             ?     2960           
  Partials           ?        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@niyobertin niyobertin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niyobertin niyobertin removed the WIP Work in progress label Nov 12, 2024
@mpanoathos mpanoathos added the Needs Reviews A pull request need reviews to be merged label Nov 12, 2024
@ncutixavier ncutixavier merged commit a493b43 into develop Nov 13, 2024
2 checks passed
@ncutixavier ncutixavier deleted the fx-coordinator-remove-trainne branch November 13, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fighters Team Needs Reviews A pull request need reviews to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants