Skip to content

Conversation

@shema-surge
Copy link
Contributor

@shema-surge shema-surge commented Nov 14, 2024

PR Description

This PR fixes the rating system and conforms to the new design

Description of tasks that were expected to be completed

  1. Added Sprint Model, Schema and Resolvers
  2. Refactored Rating model, removed tempdatas model and refactored ratingsResolvers.ts
  3. Moved Rating schemas from index.ts to a separate rating.schema.ts file

Functionality

How does this works, add some information that maybe needed in testing

How has this been tested?

This functionality was tested in Apollo Sandbox

PR Checklist:

  • Task 1. Added Sprint Model, Schema and Resolvers
  • Task 2. Refactored Rating model, removed tempdatas model and refactored ratingsResolvers.ts
  • Task 3. Moved Rating schemas from index.ts to a separate rating.schema.ts file

Track PR

Trello Link (#DP-?)

Screenshots (If appropriate)

(Images)

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 3.62319% with 266 lines in your changes missing coverage. Please review.

Project coverage is 9.81%. Comparing base (849ef20) to head (6b2278d).

Files with missing lines Patch % Lines
src/resolvers/ratingsResolvers.ts 0.00% 203 Missing ⚠️
src/resolvers/sprint.resolvers.ts 0.00% 49 Missing ⚠️
src/validations/index.ts 44.44% 10 Missing ⚠️
src/models/sprint.model.ts 0.00% 2 Missing ⚠️
src/schema/rating.schema.ts 0.00% 1 Missing ⚠️
src/schema/sprint.schema.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           fix/helpers-utils-types    #423      +/-   ##
==========================================================
- Coverage                    10.04%   9.81%   -0.23%     
==========================================================
  Files                           91      95       +4     
  Lines                         3126    3239     +113     
  Branches                       730     738       +8     
==========================================================
+ Hits                           314     318       +4     
- Misses                        2807    2916     +109     
  Partials                         5       5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@shema-surge shema-surge force-pushed the fix/helpers-utils-types branch 2 times, most recently from 00e0f7a to 849ef20 Compare November 20, 2024 09:10
@shema-surge shema-surge changed the title add sprints model, fix ratings, remove tempdatas model Refactor rating system Nov 20, 2024
@shema-surge shema-surge changed the title Refactor rating system Refactor ratings Nov 20, 2024
@shema-surge shema-surge force-pushed the fix/ratings branch 2 times, most recently from 12ac3dc to 98aeda1 Compare November 22, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants