Skip to content

Conversation

@mpanoathos
Copy link
Contributor

@mpanoathos mpanoathos commented Nov 18, 2024

PR Description

This PR includes : After signup admin,coordinator,TTL are able to receive their Login details : email, password via email

Description of tasks that were expected to be completed

  • Condition checking if user is not trainee
  • Email to user

How has this been tested?

  • Clone this repository, Navigate to branch git checkout ft-non-trainee-invitations
  • Run server npm run dev
  • Use this pr review

PR Checklist:

  • Task 1.
  • Task 2.
  • Task 3.
  • Task n.

Track PR

#431

Screenshots (If appropriate)

image
image

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@6fd2a27). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/userResolver.ts 40.00% 3 Missing ⚠️
src/utils/templates/nonTraineeTemplate.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #433   +/-   ##
==========================================
  Coverage           ?   16.40%           
==========================================
  Files              ?       97           
  Lines              ?     3840           
  Branches           ?     1091           
==========================================
  Hits               ?      630           
  Misses             ?     3199           
  Partials           ?       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mpanoathos mpanoathos force-pushed the ft-non-trainee-invitations branch from 49ea640 to 5d7d94a Compare November 20, 2024 06:23
@ceelogre ceelogre temporarily deployed to ft-non-trainee-invitations - devpulse-backend PR #433 November 20, 2024 06:23 — with Render Destroyed
@mpanoathos mpanoathos added the Needs Reviews A pull request need reviews to be merged label Nov 20, 2024
@mpanoathos mpanoathos changed the title #431 Non-trainee-invitation #431: Non-trainee-invitations Nov 20, 2024
@mpanoathos mpanoathos self-assigned this Nov 20, 2024
@mpanoathos mpanoathos added Ready for merge The pull request has received all necessary reviews and can be merged and removed Needs Reviews A pull request need reviews to be merged labels Nov 20, 2024
@ncutixavier ncutixavier merged commit 3020be2 into develop Nov 20, 2024
2 checks passed
@ncutixavier ncutixavier deleted the ft-non-trainee-invitations branch November 20, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fighters Team Ready for merge The pull request has received all necessary reviews and can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants