-
Notifications
You must be signed in to change notification settings - Fork 4
fix(trainee dashboard) remove performance details field #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shema-surge
approved these changes
Aug 29, 2024
andremugabo
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JacquelineTuyisenge
approved these changes
Aug 30, 2024
22561d9
to
ac8aa37
Compare
Salim-54
approved these changes
Sep 4, 2024
ac8aa37
to
4870b69
Compare
4870b69
to
a46a2ad
Compare
a46a2ad
to
9848c59
Compare
9848c59
to
5370671
Compare
5370671
to
48d176f
Compare
Please resolve the conflicts |
e2de959
to
7d9957d
Compare
Bananayosostene
pushed a commit
that referenced
this pull request
Sep 6, 2024
Salim-54
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Fx: In-app notification * Fx: In-app notification * fix(trainee dashboard) remove performance details field (#436) * Fx: In-app notification * Fx: In-app notification --------- Co-authored-by: shebelle <[email protected]>
Dawaic6
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Fx: In-app notification * Fx: In-app notification * fix(trainee dashboard) remove performance details field (#436) * Fx: In-app notification * Fx: In-app notification --------- Co-authored-by: shebelle <[email protected]>
Dawaic6
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Fx: In-app notification * fix(trainee dashboard) remove performance details field (#436) * Fx: In-app notification * Fx: In-app notification --------- Co-authored-by: shebelle <[email protected]>
Salim-54
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Fx: In-app notification * fix(trainee dashboard) remove performance details field (#436) * Fx: In-app notification * Fx: In-app notification --------- Co-authored-by: Mugemane Bertin <[email protected]> Co-authored-by: shebelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
this fix removes the button
this works on the design to cover the gap of the button removed
Description of tasks that were expected to be completed
Remove performance details field for trainees #390
How has this been tested?
login as a trainee - navigate to performance tab via the sidebar - check your performance and you will notice there is no non-functional button still there
Number of Commits
1
Screenshots (If appropriate)
AFTER
BEFORE
Please check this Checklist before you submit your PR: