Skip to content

fix(trainee dashboard) remove performance details field #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

shebz2023
Copy link
Member

@shebz2023 shebz2023 commented Aug 29, 2024

PR Description

this fix removes the button
this works on the design to cover the gap of the button removed

Description of tasks that were expected to be completed

Remove performance details field for trainees #390

How has this been tested?

login as a trainee - navigate to performance tab via the sidebar - check your performance and you will notice there is no non-functional button still there

Number of Commits

1

Screenshots (If appropriate)

AFTER

Screenshot 2024-08-29 125710

BEFORE

Screenshot 2024-08-29 125836

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@shebz2023 shebz2023 self-assigned this Aug 29, 2024
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 6:48am

@shebz2023 shebz2023 requested a review from andremugabo August 30, 2024 08:08
Copy link
Contributor

@andremugabo andremugabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shebz2023 shebz2023 force-pushed the fx-remove-details-buttonfortrainees branch from ac8aa37 to 4870b69 Compare September 4, 2024 16:01
@shebz2023 shebz2023 added enhancement New feature or request and removed Ready For Merge labels Sep 4, 2024
@shebz2023 shebz2023 force-pushed the fx-remove-details-buttonfortrainees branch from 4870b69 to a46a2ad Compare September 4, 2024 16:28
@shebz2023 shebz2023 force-pushed the fx-remove-details-buttonfortrainees branch from a46a2ad to 9848c59 Compare September 4, 2024 16:50
@shebz2023 shebz2023 force-pushed the fx-remove-details-buttonfortrainees branch from 9848c59 to 5370671 Compare September 4, 2024 17:06
@Salim-54
Copy link

Salim-54 commented Sep 5, 2024

Please resolve the conflicts

@shebz2023 shebz2023 force-pushed the fx-remove-details-buttonfortrainees branch from e2de959 to 7d9957d Compare September 5, 2024 06:46
@Salim-54 Salim-54 merged commit ea1e1e3 into develop Sep 5, 2024
6 checks passed
Salim-54 pushed a commit that referenced this pull request Sep 6, 2024
* Fx: In-app notification

* Fx: In-app notification

* fix(trainee dashboard) remove performance details field  (#436)

* Fx: In-app notification

* Fx: In-app notification

---------

Co-authored-by: shebelle <[email protected]>
Dawaic6 pushed a commit that referenced this pull request Sep 9, 2024
* Fx: In-app notification

* Fx: In-app notification

* fix(trainee dashboard) remove performance details field  (#436)

* Fx: In-app notification

* Fx: In-app notification

---------

Co-authored-by: shebelle <[email protected]>
Dawaic6 pushed a commit that referenced this pull request Sep 9, 2024
* Fx: In-app notification

* fix(trainee dashboard) remove performance details field  (#436)

* Fx: In-app notification

* Fx: In-app notification

---------

Co-authored-by: shebelle <[email protected]>
Salim-54 pushed a commit that referenced this pull request Sep 9, 2024
* Fx: In-app notification

* fix(trainee dashboard) remove performance details field  (#436)

* Fx: In-app notification

* Fx: In-app notification

---------

Co-authored-by: Mugemane Bertin <[email protected]>
Co-authored-by: shebelle <[email protected]>
@ceelogre ceelogre deleted the fx-remove-details-buttonfortrainees branch September 30, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants