Skip to content

Skeleton loader match to respective layout #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

Dawaic6
Copy link
Contributor

@Dawaic6 Dawaic6 commented Aug 29, 2024

PR Description

This PR reconstructs the skeleton loaders across the entire application to better match the respective page layouts. The goal is to enhance the user experience by providing more accurate visual placeholders that align with the design and content of each page while the data is loading.

Description of tasks that were expected to be completed

  • Redesigned skeleton loaders for the ttl page to reflect the table and filter input layout.
  • Refined skeleton loaders for the Admins page to match the admin list and control components.
  • Implemented loaders for the Domains page to mirror the grid and form layout for domain management.
  • Created loaders that fit the Calendar page's calendar and event list layout.
  • Ensured consistency in loader colors, sizes, and spacing across all pages.
  • Made all skeleton loaders responsive to adapt well to different screen sizes.

How has this been tested?

Manual Testing: Verified each page's skeleton loaders to ensure they align with the respective page layout and design on various devices (desktop, tablet, mobile).

  • Navigated through each page to check that loaders appear correctly while data is being fetched.
  • Checked that the loaders are responsive and adapt well to different screen sizes.
  • Ensured no existing functionality was broken by the new loaders.

Screenshots (If appropriate)

  • calender
image - **organisation** image - ttl page image

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 0:22am

@Dawaic6 Dawaic6 self-assigned this Aug 29, 2024
@Dawaic6 Dawaic6 linked an issue Aug 29, 2024 that may be closed by this pull request
@Dawaic6 Dawaic6 force-pushed the Skeleton-loader-#415 branch from d562f74 to efbcc45 Compare September 2, 2024 14:05
@Dawaic6 Dawaic6 force-pushed the Skeleton-loader-#415 branch from efbcc45 to ae4b6d9 Compare September 2, 2024 14:11
@Dawaic6 Dawaic6 force-pushed the Skeleton-loader-#415 branch from ae4b6d9 to 2af4ade Compare September 4, 2024 08:50
@Dawaic6 Dawaic6 force-pushed the Skeleton-loader-#415 branch from 2af4ade to a3f25f3 Compare September 4, 2024 08:56
@Dawaic6 Dawaic6 force-pushed the Skeleton-loader-#415 branch from a3f25f3 to 9683af4 Compare September 4, 2024 09:14
@Dawaic6 Dawaic6 force-pushed the Skeleton-loader-#415 branch from 9683af4 to 9e09cf6 Compare September 4, 2024 09:18
@Dawaic6 Dawaic6 force-pushed the Skeleton-loader-#415 branch from 9e09cf6 to 520a989 Compare September 4, 2024 09:43
@Dawaic6 Dawaic6 force-pushed the Skeleton-loader-#415 branch from 520a989 to 0c3fe09 Compare September 4, 2024 10:09
Copy link
Contributor

@andremugabo andremugabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ncutixavier ncutixavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, Unnecessary changes/formats are not allowed

Copy link

@Salim-54 Salim-54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the conflicts

* Fx: In-app notification

* fix(trainee dashboard) remove performance details field  (#436)

* Fx: In-app notification

* Fx: In-app notification

---------

Co-authored-by: shebelle <[email protected]>
@Dawaic6 Dawaic6 force-pushed the Skeleton-loader-#415 branch from 931641c to 49998b8 Compare September 9, 2024 12:21
@Salim-54 Salim-54 merged commit e322534 into develop Sep 9, 2024
6 checks passed
@ceelogre ceelogre deleted the Skeleton-loader-#415 branch September 30, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skeleton reconstruction
9 participants